Bug 121589 – Remove superfluous CSSLinearTimingFunctionValue and use switch on TimingFunction::type() in more places

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Ryosuke Niwa]

Remove superfluous CSSLinearTimingFunctionValue and use switch on TimingFunction::type() in more places

[Ryosuke Niwa]

Created attachment 212035 [details]
Cleanup

[Simon Fraser (smfr)]

Comment on attachment 212035 [details]
Cleanup

View in context: https://bugs.webkit.org/attachment.cgi?id=212035&action=review

> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:1253
> +        {
> +            const StepsTimingFunction* stepsTimingFunction = static_cast<const StepsTimingFunction*>(timingFunction);
> +            return CSSStepsTimingFunctionValue::create(stepsTimingFunction->numberOfSteps(), stepsTimingFunction->stepAtStart());
> +        }

This doesn't match our indentation style.

> Source/WebCore/page/animation/AnimationBase.cpp:605
> +        {
> +            const CubicBezierTimingFunction* function = static_cast<const CubicBezierTimingFunction*>(tf);
> +            return solveCubicBezierFunction(function->x1(), function->y1(), function->x2(), function->y2(), fractionalTime, m_animation->duration());
> +        }
> +    case TimingFunction::StepsFunction:
> +        {
> +            const StepsTimingFunction* stepsTimingFunction = static_cast<const StepsTimingFunction*>(tf);
> +            return solveStepsFunction(stepsTimingFunction->numberOfSteps(), stepsTimingFunction->stepAtStart(), fractionalTime);
> +        }

Ditto.

[Ryosuke Niwa]

Created attachment 212102 [details]
Fixed indentation style

[Ryosuke Niwa]

Committed r156125: <http://trac.webkit.org/changeset/156125>