Bug 121587 – [SVG] Handle endEvent for svg animations

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Ryosuke Niwa]

Consider merging https://chromium.googlesource.com/chromium/blink/+/4d415ca0268231aa80e3552fe21bf3480a6978f8

Handled endEvent for svg animations according to http://www.w3.org/TR/SMIL3/smil-timing.html#q135

[Radar WebKit Bug Importer]

<rdar://problem/23067140>

[Antoine Quint]

Created attachment 262882 [details]
Simple testcase

[Antoine Quint]

Created attachment 262886 [details]
Patch

[Dean Jackson]

Comment on attachment 262886 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262886&action=review

> Source/WebCore/svg/animation/SMILTimeContainer.cpp:272
>          AnimationsVector* scheduled = it.value.get();
> +        unsigned size = scheduled->size();
> +        for (unsigned n = 0; n < size; n++) {
> +            SVGSMILElement* animation = scheduled->at(n);
> +            if (!animation->hasConditionsConnected())
> +                animation->connectConditions();
> +        }

I think you can use a modern for loop here.

for (auto* animation : scheduled) {
  if (!animation->hasConditionsConnected())
    animation->connectConditions();
}

While here, we can come up with a better variable name than "it".

> Source/WebCore/svg/animation/SMILTimeContainer.cpp:276
> +    for (auto& it : m_scheduledAnimations) {
> +        AnimationsVector* scheduled = it.value.get();

Same here about the variable name.

[Antoine Quint]

Created attachment 262918 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 262918 [details]
Patch for landing

Clearing flags on attachment: 262918

Committed r190890: <http://trac.webkit.org/changeset/190890>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.