Bug 121585 - Add XHR tests checking readyState transition when abort() is invoked in various states
Summary: Add XHR tests checking readyState transition when abort() is invoked in vario...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: BlinkMergeCandidate
Depends on:
Blocks:
 
Reported: 2013-09-18 20:08 PDT by Ryosuke Niwa
Modified: 2013-09-19 10:56 PDT (History)
5 users (show)

See Also:

Attachments
Adds the test (7.12 KB, patch)
2013-09-18 20:09 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2013-09-18 20:08:45 PDT 
Add XHR tests checking readyState transition when abort() is invoked in various states
Comment 1 Ryosuke Niwa 2013-09-18 20:09:34 PDT 
Created attachment 212032 [details]
Adds the test
Comment 2 Alexey Proskuryakov 2013-09-19 09:29:32 PDT 
Comment on attachment 212032 [details]
Adds the test

View in context: https://bugs.webkit.org/attachment.cgi?id=212032&action=review

> LayoutTests/http/tests/xmlhttprequest/readystatechange-and-abort.html:5
> +<script src="../w3c/resources/testharness.js"></script>
> +<script src="../w3c/resources/testharnessreport.js"></script>

This concerns me a little - aren't w3c test resources subject to change without notice? Might be worth checking with people who work on importing these.
Comment 3 Ryosuke Niwa 2013-09-19 10:33:23 PDT 
(In reply to comment #2)
> (From update of attachment 212032 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=212032&action=review
> 
> > LayoutTests/http/tests/xmlhttprequest/readystatechange-and-abort.html:5
> > +<script src="../w3c/resources/testharness.js"></script>
> > +<script src="../w3c/resources/testharnessreport.js"></script>
> 
> This concerns me a little - aren't w3c test resources subject to change without notice? Might be worth checking with people who work on importing these.

In theory but I highly doubt they'll make frequent changes to their test harness script used by tens of thousands of tests at this point.
Comment 4 WebKit Commit Bot 2013-09-19 10:56:17 PDT 
Comment on attachment 212032 [details]
Adds the test

Clearing flags on attachment: 212032

Committed r156103: <http://trac.webkit.org/changeset/156103>
Comment 5 WebKit Commit Bot 2013-09-19 10:56:19 PDT 
All reviewed patches have been landed.  Closing bug.