Bug 121582 – [Lion] media/track/track-in-band-duplicate-tracks-when-source-changes.html fails

• Status: NEW
• Component: Media

[Ryosuke Niwa]

The test added by http://trac.webkit.org/changeset/154760 always fails on Lion:
http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Ftrack%2Ftrack-in-band-duplicate-tracks-when-source-changes.html

[Ryosuke Niwa]

Added the test expectation in http://trac.webkit.org/changeset/156077.

[Brendan Long]

Is there any way to see what the rest results are? Are in-band tracks only available on Mountain Lion or something?

[Ryosuke Niwa]

http://build.webkit.org/results/Apple%20Lion%20Debug%20WK1%20(Tests)/r156039%20(10815)/results.html

[Brendan Long]

Created attachment 212079 [details]
Skip this test on older OS X versions

It looks like in-band tracks don't work on older OS X versions. I added another line to the section that's skipping all of the other in-band track tests.

[Ryosuke Niwa]

Comment on attachment 212079 [details]
Skip this test on older OS X versions

View in context: https://bugs.webkit.org/attachment.cgi?id=212079&action=review

> LayoutTests/platform/mac/TestExpectations:1115
> +webkit.org/b/103663 [ MountainLion Lion SnowLeopard ] media/track/track-in-band-duplicate-tracks-when-source-changes.html

Please remove test expectations added in http://trac.webkit.org/changeset/156077.

[Brendan Long]

Created attachment 212080 [details]
Remove duplicate test expectation

[Brendan Long]

(In reply to comment #5)
> Please remove test expectations added in http://trac.webkit.org/changeset/156077.

Sorry, I comment #1 wrong. The duplicate test expectation is removed now.

[Brendan Long]

Was this committed?

[Alexey Proskuryakov]

> Was this committed?

No.

I don't understand this patch. Why does it add an expectation for MountainLion, does the test fail there?

[Brendan Long]

The comment above (In reply to comment #9)
> I don't understand this patch. Why does it add an expectation for MountainLion, does the test fail there?

The comment above the section I added this to says:

> # Mountain Lion and prior do not allow access to in-band text tracks

[Alexey Proskuryakov]

I am asking whether the test is actually failing. We have bots for that - if you go to <http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK1%20(Tests)/r156726%20(13408)/results.html>, you can see that it's not reported as failing.

Why is that?

[Brendan Long]

Maybe that comment is wrong..

[Brendan Long]

I grepped through the TestExpectations files and I don't see any reason why this would be skipped on Mountain Lion. My best guess is that the comment is wrong, but I don't have a machine with Mountain Lion on it, and I'm not sure how to confirm this in the code.

[Alexey Proskuryakov]

I asked our media experts, and turns out that the comment is no longer accurate. We still don't have access to cues, but we know about in-band tracks now, even on Lion.

It looks like the failures are timing related. It was suggested that the tests should probably be fixed to wait for 'trackchange'.

[Ahmad Saleem]

We have platform specific expectation but tracked in newer bug 228364.

https://searchfox.org/wubkat/source/LayoutTests/platform/ios-wk2/TestExpectations#1821

Marking this as duplicate to newer, would be appropriate IMO. Any input?