RESOLVED FIXED 121575
Move logicalHeightForLine out from LineWidth.h 
https://bugs.webkit.org/show_bug.cgi?id=121575
Summary Move logicalHeightForLine out from LineWidth.h
Zoltan Horvath
Reported 2013-09-18 14:49:41 PDT
In bug #121107 I moved logicalHeightForLine into LineWidth.h as part of LineWidth refactoring. Now it's time to move logicalHeightForLine to a member function of RenderBlock.
Attachments
proposed patch (8.27 KB, patch)
2013-09-18 14:52 PDT, Zoltan Horvath 		no flags
DetailsFormatted DiffDiff
proposed patch (9.23 KB, patch)
2013-09-18 16:58 PDT, Zoltan Horvath 		no flags
DetailsFormatted DiffDiff
proposed patch - updated changelog (9.45 KB, patch)
2013-09-19 09:33 PDT, Zoltan Horvath 		hyatt: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
updated to tot (9.29 KB, patch)
2013-09-20 13:18 PDT, Zoltan Horvath 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Zoltan Horvath
Comment 1 2013-09-18 14:52:33 PDT
Created attachment 212022 [details] proposed patch
Zoltan Horvath
Comment 2 2013-09-18 16:58:56 PDT
Created attachment 212029 [details] proposed patch
Zoltan Horvath
Comment 3 2013-09-19 09:33:34 PDT
Created attachment 212075 [details] proposed patch - updated changelog
Dave Hyatt
Comment 4 2013-09-20 11:48:20 PDT
Comment on attachment 212075 [details] proposed patch - updated changelog r=me
WebKit Commit Bot
Comment 5 2013-09-20 11:51:48 PDT
Comment on attachment 212075 [details] proposed patch - updated changelog Rejecting attachment 212075 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 212075, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: FAILED -- saving rejects to file Source/WebCore/rendering/LineWidth.cpp.rej patching file Source/WebCore/rendering/LineWidth.h patching file Source/WebCore/rendering/RenderBlock.cpp Hunk #1 succeeded at 5642 (offset -2 lines). patching file Source/WebCore/rendering/RenderBlock.h patching file Source/WebCore/rendering/RenderBlockLineLayout.cpp Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'David Hyatt']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/1873322
Zoltan Horvath
Comment 6 2013-09-20 13:18:12 PDT
Created attachment 212212 [details] updated to tot
WebKit Commit Bot
Comment 7 2013-09-20 13:52:38 PDT
Comment on attachment 212212 [details] updated to tot Clearing flags on attachment: 212212 Committed r156197: <http://trac.webkit.org/changeset/156197>
WebKit Commit Bot
Comment 8 2013-09-20 13:52:41 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.