WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
121568
Replace use of OwnArrayPtr<Foo> with std::unique_ptr<Foo[]> in WebKit and WebKit2
https://bugs.webkit.org/show_bug.cgi?id=121568
Summary
Replace use of OwnArrayPtr<Foo> with std::unique_ptr<Foo[]> in WebKit and Web...
Sam Weinig
Reported
2013-09-18 13:28:39 PDT
Replace use of OwnArrayPtr<Foo> with std::unique_ptr<Foo[]> in WebKit and WebKit2
Attachments
Patch
(14.95 KB, patch)
2013-09-18 13:29 PDT
,
Sam Weinig
kling
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Sam Weinig
Comment 1
2013-09-18 13:29:34 PDT
Created
attachment 212016
[details]
Patch
Sam Weinig
Comment 2
2013-09-18 14:44:47 PDT
Committed
r156063
: <
http://trac.webkit.org/changeset/156063
>
Brent Fulgham
Comment 3
2013-09-18 15:25:48 PDT
Comment on
attachment 212016
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=212016&action=review
This change breaks the Windows build.
> Source/WebKit/win/WebHistory.h:150 > + std::unique<DATE[]> m_orderedLastVisitedDays;
Should this have been std::unique_ptr? Isn't std::unique an algorithm?
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug