Bug 121568 - Replace use of OwnArrayPtr<Foo> with std::unique_ptr<Foo[]> in WebKit and WebKit2
Summary: Replace use of OwnArrayPtr<Foo> with std::unique_ptr<Foo[]> in WebKit and Web...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-18 13:28 PDT by Sam Weinig
Modified: 2013-09-18 15:25 PDT (History)
4 users (show)

See Also:

Attachments
Patch (14.95 KB, patch)
2013-09-18 13:29 PDT, Sam Weinig 		kling: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2013-09-18 13:28:39 PDT 
Replace use of OwnArrayPtr<Foo> with std::unique_ptr<Foo[]> in WebKit and WebKit2
Comment 1 Sam Weinig 2013-09-18 13:29:34 PDT 
Created attachment 212016 [details]
Patch
Comment 2 Sam Weinig 2013-09-18 14:44:47 PDT 
Committed r156063: <http://trac.webkit.org/changeset/156063>
Comment 3 Brent Fulgham 2013-09-18 15:25:48 PDT 
Comment on attachment 212016 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=212016&action=review

This change breaks the Windows build.

> Source/WebKit/win/WebHistory.h:150
> +    std::unique<DATE[]> m_orderedLastVisitedDays;

Should this have been std::unique_ptr?  Isn't std::unique an algorithm?