Bug 121566 - REGRESSION (r129451): run-safari --no-saved-state is broken
Summary: REGRESSION (r129451): run-safari --no-saved-state is broken
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-18 13:01 PDT by Alexey Proskuryakov
Modified: 2013-09-19 12:22 PDT (History)
2 users (show)

See Also:

Attachments
proposed fix (1.35 KB, patch)
2013-09-18 13:11 PDT, Alexey Proskuryakov 		mrowe: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2013-09-18 13:01:29 PDT 
It looks like run-safari --no-saved-state doesn't work with some Perl versions, the argument is ignored.
Comment 1 Alexey Proskuryakov 2013-09-18 13:10:09 PDT 
Looking at the code, I don't see how it could possibly work anywhere, I probably made a mistake in my testing.

<http://trac.webkit.org/r129451> is very clearly the culprit.
Comment 2 Alexey Proskuryakov 2013-09-18 13:11:31 PDT 
Created attachment 212015 [details]
proposed fix
Comment 3 Alexey Proskuryakov 2013-09-18 13:30:35 PDT 
Committed <http://trac.webkit.org/r156057> with an additional change to suppress AppKit warning logging.
Comment 4 Alexey Proskuryakov 2013-09-19 12:22:04 PDT 
> an additional change to suppress AppKit warning logging.

This didn't actually work, removed that part in r156109.