WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
121564
RefPtrHashMap should work with move only types
https://bugs.webkit.org/show_bug.cgi?id=121564
Summary
RefPtrHashMap should work with move only types
Anders Carlsson
Reported
2013-09-18 12:18:36 PDT
RefPtrHashMap should work with move only types
Attachments
Patch
(15.66 KB, patch)
2013-09-18 12:20 PDT
,
Anders Carlsson
kling
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Anders Carlsson
Comment 1
2013-09-18 12:20:35 PDT
Created
attachment 212010
[details]
Patch
WebKit Commit Bot
Comment 2
2013-09-18 12:21:28 PDT
Attachment 212010
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/runtime/VM.cpp', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/RefPtrHashMap.h', u'Source/WebCore/ChangeLog', u'Source/WebCore/bridge/IdentifierRep.cpp', u'Source/WebCore/page/PageGroup.cpp', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/Plugins/Hosted/ProxyInstance.mm', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/UIProcess/Storage/StorageManager.cpp', u'Source/WebKit2/WebProcess/Storage/StorageNamespaceImpl.cpp']" exit_code: 1 Source/WebCore/page/PageGroup.cpp:268: Missing spaces around >> [whitespace/operators] [3] Source/WTF/wtf/RefPtrHashMap.h:90: Missing spaces around && [whitespace/operators] [3] Source/WTF/wtf/RefPtrHashMap.h:91: Missing spaces around && [whitespace/operators] [3] Source/WTF/wtf/RefPtrHashMap.h:96: Missing spaces around && [whitespace/operators] [3] Source/WTF/wtf/RefPtrHashMap.h:97: Missing spaces around && [whitespace/operators] [3] Source/WTF/wtf/RefPtrHashMap.h:109: Missing spaces around && [whitespace/operators] [3] Source/WTF/wtf/RefPtrHashMap.h:112: Missing spaces around && [whitespace/operators] [3] Source/WebKit2/WebProcess/Storage/StorageNamespaceImpl.cpp:88: Missing spaces around >> [whitespace/operators] [3] Source/WebKit2/UIProcess/Storage/StorageManager.cpp:354: Missing spaces around >> [whitespace/operators] [3] Total errors found: 9 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andreas Kling
Comment 3
2013-09-18 12:42:14 PDT
Comment on
attachment 212010
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=212010&action=review
r=me but dude...
> Source/JavaScriptCore/runtime/VM.cpp:495 > - SourceProviderCacheMap::AddResult addResult = sourceProviderCacheMap.add(sourceProvider, 0); > + SourceProviderCacheMap::AddResult addResult = sourceProviderCacheMap.add(sourceProvider, nullptr);
auto
>> Source/WebCore/page/PageGroup.cpp:268 >> - HashMap<RefPtr<SecurityOrigin>, RefPtr<StorageNamespace> >::AddResult result = m_transientLocalStorageMap.add(topOrigin, 0); >> + HashMap<RefPtr<SecurityOrigin>, RefPtr<StorageNamespace>>::AddResult result = m_transientLocalStorageMap.add(topOrigin, nullptr); > > Missing spaces around >> [whitespace/operators] [3]
auto
> Source/WebKit2/UIProcess/Storage/StorageManager.cpp:271 > - HashMap<RefPtr<SecurityOrigin>, StorageArea*>::AddResult result = m_storageAreaMap.add(securityOrigin, 0); > + HashMap<RefPtr<SecurityOrigin>, StorageArea*>::AddResult result = m_storageAreaMap.add(securityOrigin, nullptr);
auto
>> Source/WebKit2/UIProcess/Storage/StorageManager.cpp:354 >> + HashMap<RefPtr<SecurityOrigin>, RefPtr<StorageArea>>::AddResult result = m_storageAreaMap.add(securityOrigin, nullptr); > > Missing spaces around >> [whitespace/operators] [3]
auto
>> Source/WebKit2/WebProcess/Storage/StorageNamespaceImpl.cpp:88 >> - HashMap<RefPtr<WebCore::SecurityOrigin>, RefPtr<StorageAreaMap>>::AddResult result = m_storageAreaMaps.add(securityOrigin.get(), 0); >> + HashMap<RefPtr<WebCore::SecurityOrigin>, RefPtr<StorageAreaMap>>::AddResult result = m_storageAreaMaps.add(securityOrigin.get(), nullptr); > > Missing spaces around >> [whitespace/operators] [3]
auto
Anders Carlsson
Comment 4
2013-09-18 12:51:15 PDT
Committed
r156056
: <
http://trac.webkit.org/changeset/156056
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug