Bug 121564 – RefPtrHashMap should work with move only types

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Anders Carlsson]

RefPtrHashMap should work with move only types

[Anders Carlsson]

Created attachment 212010 [details]
Patch

[WebKit Commit Bot]

Attachment 212010 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/runtime/VM.cpp', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/RefPtrHashMap.h', u'Source/WebCore/ChangeLog', u'Source/WebCore/bridge/IdentifierRep.cpp', u'Source/WebCore/page/PageGroup.cpp', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/Plugins/Hosted/ProxyInstance.mm', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/UIProcess/Storage/StorageManager.cpp', u'Source/WebKit2/WebProcess/Storage/StorageNamespaceImpl.cpp']" exit_code: 1
Source/WebCore/page/PageGroup.cpp:268:  Missing spaces around >>  [whitespace/operators] [3]
Source/WTF/wtf/RefPtrHashMap.h:90:  Missing spaces around &&  [whitespace/operators] [3]
Source/WTF/wtf/RefPtrHashMap.h:91:  Missing spaces around &&  [whitespace/operators] [3]
Source/WTF/wtf/RefPtrHashMap.h:96:  Missing spaces around &&  [whitespace/operators] [3]
Source/WTF/wtf/RefPtrHashMap.h:97:  Missing spaces around &&  [whitespace/operators] [3]
Source/WTF/wtf/RefPtrHashMap.h:109:  Missing spaces around &&  [whitespace/operators] [3]
Source/WTF/wtf/RefPtrHashMap.h:112:  Missing spaces around &&  [whitespace/operators] [3]
Source/WebKit2/WebProcess/Storage/StorageNamespaceImpl.cpp:88:  Missing spaces around >>  [whitespace/operators] [3]
Source/WebKit2/UIProcess/Storage/StorageManager.cpp:354:  Missing spaces around >>  [whitespace/operators] [3]
Total errors found: 9 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Andreas Kling]

Comment on attachment 212010 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=212010&action=review

r=me but dude...

> Source/JavaScriptCore/runtime/VM.cpp:495
> -    SourceProviderCacheMap::AddResult addResult = sourceProviderCacheMap.add(sourceProvider, 0);
> +    SourceProviderCacheMap::AddResult addResult = sourceProviderCacheMap.add(sourceProvider, nullptr);

auto

>> Source/WebCore/page/PageGroup.cpp:268
>> -    HashMap<RefPtr<SecurityOrigin>, RefPtr<StorageNamespace> >::AddResult result = m_transientLocalStorageMap.add(topOrigin, 0);
>> +    HashMap<RefPtr<SecurityOrigin>, RefPtr<StorageNamespace>>::AddResult result = m_transientLocalStorageMap.add(topOrigin, nullptr);
> 
> Missing spaces around >>  [whitespace/operators] [3]

auto

> Source/WebKit2/UIProcess/Storage/StorageManager.cpp:271
> -    HashMap<RefPtr<SecurityOrigin>, StorageArea*>::AddResult result = m_storageAreaMap.add(securityOrigin, 0);
> +    HashMap<RefPtr<SecurityOrigin>, StorageArea*>::AddResult result = m_storageAreaMap.add(securityOrigin, nullptr);

auto

>> Source/WebKit2/UIProcess/Storage/StorageManager.cpp:354
>> +    HashMap<RefPtr<SecurityOrigin>, RefPtr<StorageArea>>::AddResult result = m_storageAreaMap.add(securityOrigin, nullptr);
> 
> Missing spaces around >>  [whitespace/operators] [3]

auto

>> Source/WebKit2/WebProcess/Storage/StorageNamespaceImpl.cpp:88
>> -    HashMap<RefPtr<WebCore::SecurityOrigin>, RefPtr<StorageAreaMap>>::AddResult result = m_storageAreaMaps.add(securityOrigin.get(), 0);
>> +    HashMap<RefPtr<WebCore::SecurityOrigin>, RefPtr<StorageAreaMap>>::AddResult result = m_storageAreaMaps.add(securityOrigin.get(), nullptr);
> 
> Missing spaces around >>  [whitespace/operators] [3]

auto

[Anders Carlsson]

Committed r156056: <http://trac.webkit.org/changeset/156056>