Bug 121535 - WinLauncher needs better url handling
Summary: WinLauncher needs better url handling
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P3 Minor
Assignee: Nobody
Depends on:
Reported: 2013-09-17 21:02 PDT by Alex Christensen
Modified: 2013-09-18 10:20 PDT (History)
2 users (show)

See Also:

Patch (1.82 KB, patch)
2013-09-17 21:05 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2013-09-17 21:02:07 PDT
BrowserWindowController.m has a function called addProtocolIfNecessary which prepends "http://" if "://" is not found in the url of MiniBrowser.  A similar behaviour can be achieved with a simple one line change that makes it so if you type "webkit.org" into WinLauncher you'll get to your favourite website instead of having to type "http://www.webkit.org/".

Also, we defined our own macro MAX_URL_LENGTH which is 1024 instead of INTERNET_MAX_URL_LENGTH from WinInet.h which is 2083.  This should be consistent.

This makes WinLauncher more stable and user friendly.
Comment 1 Alex Christensen 2013-09-17 21:05:31 PDT
Created attachment 211969 [details]
Comment 2 Brent Fulgham 2013-09-17 21:55:43 PDT
Comment on attachment 211969 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=211969&action=review


> Tools/WinLauncher/WinLauncher.cpp:-875
> -

Comment 3 WebKit Commit Bot 2013-09-18 10:20:53 PDT
Comment on attachment 211969 [details]

Clearing flags on attachment: 211969

Committed r156048: <http://trac.webkit.org/changeset/156048>
Comment 4 WebKit Commit Bot 2013-09-18 10:20:54 PDT
All reviewed patches have been landed.  Closing bug.