Bug 121521 - run-jsc-stress-tests fails with ruby version 2
Summary: run-jsc-stress-tests fails with ruby version 2
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-09-17 14:29 PDT by Michael Saboff
Modified: 2013-09-17 14:43 PDT (History)
0 users

See Also:


Attachments
Patch (1.26 KB, patch)
2013-09-17 14:36 PDT, Michael Saboff
jberlin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2013-09-17 14:29:36 PDT
When running run-javascriptcore-tests with ruby version 2 installed, we get this error:

Error: #<LoadError: cannot load such file -- highline>
Tools/Scripts/run-jsc-stress-tests:330:in `block (4 levels) in <main>': invalid byte sequence in US-ASCII (ArgumentError)
	from Tools/Scripts/run-jsc-stress-tests:328:in `each_line'
	from Tools/Scripts/run-jsc-stress-tests:328:in `block (3 levels) in <main>'
	from Tools/Scripts/run-jsc-stress-tests:326:in `open'
	from Tools/Scripts/run-jsc-stress-tests:326:in `block (2 levels) in <main>'
	from Tools/Scripts/run-jsc-stress-tests:320:in `each'
	from Tools/Scripts/run-jsc-stress-tests:320:in `block in <main>'
	from Tools/Scripts/run-jsc-stress-tests:286:in `each'
	from Tools/Scripts/run-jsc-stress-tests:286:in `<main>'

<rdar://problem/15010705>
Comment 1 Michael Saboff 2013-09-17 14:36:26 PDT
Created attachment 211944 [details]
Patch

It appears that ruby version 2 uses the LANG environment variable to figure what character set to use when reading a file.  Setting to a UTF8 language makes ruby happy.
Comment 2 Michael Saboff 2013-09-17 14:43:45 PDT
Committed r155999: <http://trac.webkit.org/changeset/155999>