Bug 121520 - DFG should use the (x & 0x7fffffff) trick for doing overflow and neg-zero checks on negation in one go
Summary: DFG should use the (x & 0x7fffffff) trick for doing overflow and neg-zero che...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-17 14:26 PDT by Filip Pizlo
Modified: 2013-09-17 18:03 PDT (History)
7 users (show)

See Also:


Attachments
the patch (3.00 KB, patch)
2013-09-17 14:27 PDT, Filip Pizlo
oliver: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2013-09-17 14:26:31 PDT
The baseline JIT uses it already.  It's a silly oversight that the DFG doesn't.
Comment 1 Filip Pizlo 2013-09-17 14:27:18 PDT
Created attachment 211942 [details]
the patch
Comment 2 Filip Pizlo 2013-09-17 18:03:50 PDT
Landed in http://trac.webkit.org/changeset/156016