Bug 121518 - The way FixupPhase uses alwaysUnboxSimplePrimitives() is almost certainly wrong
Summary: The way FixupPhase uses alwaysUnboxSimplePrimitives() is almost certainly wrong
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-17 14:15 PDT by Filip Pizlo
Modified: 2013-09-17 14:15 PDT (History)
7 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2013-09-17 14:15:37 PDT
What it wants to do is say that even if a local isn't used as a simple primitive but is predicted to be a simple primitive, then it should be unboxed.  But what the logic currently does is asks for a local to be unboxed even if it's not predicted to have a type that is a candidate for unboxing; i.e. it accomplishes nothing.  More likely it should walk all locals up-front and if they have a "simple primitive" prediction and alwaysUnboxSimplePrimitives() is true, then mark them as being profitable.