Bug 121506 - Add isTextOrBR() and use it
Summary: Add isTextOrBR() and use it
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-17 10:55 PDT by Antti Koivisto
Modified: 2013-09-17 11:09 PDT (History)
1 user (show)

See Also:

Attachments
patch (9.81 KB, patch)
2013-09-17 10:59 PDT, Antti Koivisto 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2013-09-17 10:55:55 PDT 
It is a popular test.
Comment 1 Antti Koivisto 2013-09-17 10:59:02 PDT 
Created attachment 211923 [details]
patch
Comment 2 Darin Adler 2013-09-17 11:04:51 PDT 
Comment on attachment 211923 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=211923&action=review

> Source/WebCore/rendering/RenderCounter.cpp:111
> -    if (object->isText() && !object->isBR())
> +    if (object->isText())

Aha! ;-)

> Source/WebCore/rendering/RenderTreeAsText.cpp:592
> -    if (o.isText() && !o.isBR()) {
> +    if (o.isText()) {

Glad this made you find these.
Comment 3 Antti Koivisto 2013-09-17 11:09:15 PDT 
https://trac.webkit.org/r155975