Bug 121501 - [CSS Regions] Layout Test for selection direction
Summary: [CSS Regions] Layout Test for selection direction
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Manuel Rego Casasnovas
URL:
Keywords:
Depends on:
Blocks: 118668
  Show dependency treegraph
 
Reported: 2013-09-17 09:55 PDT by Manuel Rego Casasnovas
Modified: 2013-09-17 11:03 PDT (History)
4 users (show)

See Also:


Attachments
Patch (4.46 KB, patch)
2013-09-17 10:04 PDT, Manuel Rego Casasnovas
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Manuel Rego Casasnovas 2013-09-17 09:55:18 PDT
Selection is based in DOM tree, so if have the following HTML structure:
<div id="source" style="-webkit-flow-into: content;">inside region inside region inside region</div>
<div id="outside-region">outside region outside region outside region</div>
<div id="region" style="-webkit-flow-from: content;"></div>

If you select text from "outside region" to "inside region" the highlighted area is exactly the opposite to what the user is actually selecting.

This might seem weird from the user point of view, but it is ok following the DOM tree according to editing specs (https://dvcs.w3.org/hg/editing/raw-file/tip/editing.html).

This was not working since r139197 (because of it didn't allow to select content from different flow threads) and it got fixed in r155058. So, we should add a Layout Test to avoid break it again in the future without noticing.
Comment 1 Manuel Rego Casasnovas 2013-09-17 10:04:26 PDT
Created attachment 211920 [details]
Patch
Comment 2 WebKit Commit Bot 2013-09-17 11:03:38 PDT
Comment on attachment 211920 [details]
Patch

Clearing flags on attachment: 211920

Committed r155974: <http://trac.webkit.org/changeset/155974>
Comment 3 WebKit Commit Bot 2013-09-17 11:03:41 PDT
All reviewed patches have been landed.  Closing bug.