Bug 121499 – Shrink SVGElement::cssPropertyIdForSVGAttributeName and cssPropertyToTypeMap

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Darin Adler]

Shrink SVGElement::cssPropertyIdForSVGAttributeName and cssPropertyToTypeMap

[Darin Adler]

Created attachment 211917 [details]
Patch

[Andreas Kling]

Comment on attachment 211917 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=211917&action=review

r=me

> Source/WebCore/svg/SVGElement.cpp:149
> +    for (unsigned i = 0; i < WTF_ARRAY_LENGTH(attributeNames); ++i) {
> +        const AtomicString& localName = attributeNames[i]->localName();
> +        map.add(localName.impl(), cssPropertyID(localName));
> +    }

Can we reserve the necessary map capacity up front to avoid rehashing somehow?

> Source/WebCore/svg/SVGElement.cpp:222
> +    for (unsigned i = 0; i < WTF_ARRAY_LENGTH(table); ++i)
> +        map.add(table[i].attributeName.impl(), table[i].type);

Same question.

[Darin Adler]

Committed r155969: <http://trac.webkit.org/changeset/155969>