Bug 121485 – [Win] TestWebKitAPI does not compile.

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

There is currently a few compile errors in BitmapImageEmptyFrameTest in TestWebKitAPI, because it is no longer allowed to inherit from WebCore::BitmapImage, which the test relies on.

Created attachment 211895 [details]
Patch

[Brent Fulgham]

Comment on attachment 211895 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=211895&action=review

I have a few questions, but I think this looks good.  I'll r+ it and trust that you'll adjust things if you need to :-)

> Tools/TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:44
> +    auto hbmp = ::CreateDIBSection(0, &bitmapInfo, DIB_RGB_COLORS, 0, 0, 0);

Does this need to be cleaned up somewhere? I can't tell (with a few seconds checking) whether we need to delete this GDI object.

Otherwise looks good to me.

> Tools/TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:48
> +    if (bitmapImageTest) {

I would prefer an early exit, but this is fine.

> Tools/TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:53
> +        HBITMAP hBitmap = CreateBitmap(sz.width(), sz.height(), 1, 32, bits);

Does this bitmap need to be destroyed to be correct in our GDI/memory handling?

Created attachment 211985 [details]
Patch

Thanks for reviewing, all valid points, updated patch :)

[Brent Fulgham]

Comment on attachment 211985 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 211985 [details]
Patch

Clearing flags on attachment: 211985

Committed r156045: <http://trac.webkit.org/changeset/156045>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.