Bug 121484 - [GTK] Don't make the GObject DOM bindings API break test fatal
Summary: [GTK] Don't make the GObject DOM bindings API break test fatal
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alberto Garcia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-17 05:09 PDT by Alberto Garcia
Modified: 2013-09-17 05:16 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.71 KB, patch)
2013-09-17 05:11 PDT, Alberto Garcia
cgarcia: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alberto Garcia 2013-09-17 05:09:45 PDT
This test may easily give false positives, because the API can vary
depending on the compilation options.

For example, if you run configure with the default options, video
track support will be disabled, which will produce this error:

API incompatibility detected in GObject DOM bindings
@@ -14,7 +14,6 @@
 WebKitDOMAttr* webkit_dom_element_set_attribute_node_ns(WebKitDOMElement*, WebKitDOMAttr*, GError**)
 WebKitDOMAudioTrack* webkit_dom_audio_track_list_get_track_by_id(WebKitDOMAudioTrackList*, const gchar*)
 WebKitDOMAudioTrack* webkit_dom_audio_track_list_item(WebKitDOMAudioTrackList*, gulong)
-WebKitDOMAudioTrackList* webkit_dom_html_media_element_get_audio_tracks(WebKitDOMHTMLMediaElement*)
 WebKitDOMBarProp* webkit_dom_dom_window_get_locationbar(WebKitDOMDOMWindow*)
 WebKitDOMBarProp* webkit_dom_dom_window_get_menubar(WebKitDOMDOMWindow*)
 WebKitDOMBarProp* webkit_dom_dom_window_get_personalbar(WebKitDOMDOMWindow*)
[...]

Until we don't figure out a way to handle this (see bug 121481) this
check shouldn't be made fatal.
Comment 1 Alberto Garcia 2013-09-17 05:11:29 PDT
Created attachment 211889 [details]
Patch
Comment 2 Carlos Garcia Campos 2013-09-17 05:12:51 PDT
Comment on attachment 211889 [details]
Patch

Excellent, thanks!
Comment 3 Alberto Garcia 2013-09-17 05:16:03 PDT
Committed r155948: <http://trac.webkit.org/changeset/155948>