Bug 121482 - REGRESSION(r155910): WebKit nightly builds don't load any page
Summary: REGRESSION(r155910): WebKit nightly builds don't load any page
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-17 05:03 PDT by Mihnea Ovidenie
Modified: 2013-09-17 10:20 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.44 KB, patch)
2013-09-17 05:05 PDT, Mihnea Ovidenie 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mihnea Ovidenie 2013-09-17 05:03:15 PDT 
C++ style comments in wtf/Platform.h are not processed correctly, we have to replace them with C style comments.
Comment 1 Mihnea Ovidenie 2013-09-17 05:05:59 PDT 
Created attachment 211888 [details]
Patch
Comment 2 WebKit Commit Bot 2013-09-17 05:39:35 PDT 
Comment on attachment 211888 [details]
Patch

Clearing flags on attachment: 211888

Committed r155950: <http://trac.webkit.org/changeset/155950>
Comment 3 WebKit Commit Bot 2013-09-17 05:39:37 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Alexey Proskuryakov 2013-09-17 10:03:18 PDT 
That's a very late failure. I'm not even sure how this is possible.

Is there a way to make it so that wrong comment style would cause a build failure instead of runtime failure, so that this wouldn't happen in the future?
Comment 5 Mihnea Ovidenie 2013-09-17 10:14:28 PDT 
(In reply to comment #4)
> That's a very late failure. I'm not even sure how this is possible.
> 
> Is there a way to make it so that wrong comment style would cause a build failure instead of runtime failure, so that this wouldn't happen in the future?

That would be great because it already happened in https://bugs.webkit.org/show_bug.cgi?id=114752.
Comment 6 Alexey Proskuryakov 2013-09-17 10:20:10 PDT 
I see, so it's sandbox profile generation.