Bug 121480 - [Win] WebKit fails to link.
Summary: [Win] WebKit fails to link.
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-17 04:54 PDT by peavo
Modified: 2013-09-17 10:22 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.61 KB, patch)
2013-09-17 05:00 PDT, peavo 		darin: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description peavo 2013-09-17 04:54:27 PDT 
WebKit currently fails to link with the following message:

WebKit.exp : error LNK2001: unresolved external symbol "public: unsigned int __thiscall WebCore::Node::numberOfScopedHTMLStyleChildren(void)const " (?numberOfScopedHTMLStyleChildren@Node@WebCore@@QBEIXZ)
Comment 1 peavo 2013-09-17 05:00:23 PDT 
Created attachment 211886 [details]
Patch
Comment 2 Darin Adler 2013-09-17 07:47:10 PDT 
Comment on attachment 211886 [details]
Patch

Looks fine if the patch applies and fixes the build.
Comment 3 Darin Adler 2013-09-17 07:47:30 PDT 
Comment on attachment 211886 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=211886&action=review

> Source/WebKit/ChangeLog:1
> +2013-09-17  peavo@outlook.com  <peavo@outlook.com>

This line is supposed to have a human readable name and an email address, not an email address twice.
Comment 4 WebKit Commit Bot 2013-09-17 07:48:58 PDT 
Comment on attachment 211886 [details]
Patch

Rejecting attachment 211886 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 211886, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
ode: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 2 diffs from patch file(s).
patching file Source/WebKit/ChangeLog
patching file Source/WebKit/WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in
Hunk #1 FAILED at 252.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Darin Adler']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/1877735
Comment 5 peavo 2013-09-17 10:22:41 PDT 
Already fixed by r155939, it seems :)