RESOLVED INVALID 121480
[Win] WebKit fails to link. 
https://bugs.webkit.org/show_bug.cgi?id=121480
Summary [Win] WebKit fails to link.
peavo
Reported 2013-09-17 04:54:27 PDT
WebKit currently fails to link with the following message: WebKit.exp : error LNK2001: unresolved external symbol "public: unsigned int __thiscall WebCore::Node::numberOfScopedHTMLStyleChildren(void)const " (?numberOfScopedHTMLStyleChildren@Node@WebCore@@QBEIXZ)
Attachments
Patch (1.61 KB, patch)
2013-09-17 05:00 PDT, peavo 		darin: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
peavo
Comment 1 2013-09-17 05:00:23 PDT
Created attachment 211886 [details] Patch
Darin Adler
Comment 2 2013-09-17 07:47:10 PDT
Comment on attachment 211886 [details] Patch Looks fine if the patch applies and fixes the build.
Darin Adler
Comment 3 2013-09-17 07:47:30 PDT
Comment on attachment 211886 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=211886&action=review > Source/WebKit/ChangeLog:1 > +2013-09-17 peavo@outlook.com <peavo@outlook.com> This line is supposed to have a human readable name and an email address, not an email address twice.
WebKit Commit Bot
Comment 4 2013-09-17 07:48:58 PDT
Comment on attachment 211886 [details] Patch Rejecting attachment 211886 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 211886, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: ode: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 2 diffs from patch file(s). patching file Source/WebKit/ChangeLog patching file Source/WebKit/WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in Hunk #1 FAILED at 252. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Darin Adler']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/1877735
peavo
Comment 5 2013-09-17 10:22:41 PDT
Already fixed by r155939, it seems :)
Note You need to log in before you can comment on or make changes to this bug.