WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 121479
Move text caret rect computation to root inline box
https://bugs.webkit.org/show_bug.cgi?id=121479
Summary
Move text caret rect computation to root inline box
Antti Koivisto
Reported
2013-09-17 04:03:39 PDT
For future code sharing.
Attachments
patch
(6.26 KB, patch)
2013-09-17 04:10 PDT
,
Antti Koivisto
kling
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Antti Koivisto
Comment 1
2013-09-17 04:10:42 PDT
Created
attachment 211884
[details]
patch
Andreas Kling
Comment 2
2013-09-17 04:19:14 PDT
Comment on
attachment 211884
[details]
patch View in context:
https://bugs.webkit.org/attachment.cgi?id=211884&action=review
> Source/WebCore/rendering/RootInlineBox.h:138 > + IntRect computeCaretRect(float left, unsigned caretWidth, LayoutUnit* extraWidthToEndOfLine);
Can this be const?
Antti Koivisto
Comment 3
2013-09-17 05:35:43 PDT
https://trac.webkit.org/r155949
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug