WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
121464
Remove unused function didSetSelectionTypesForPasteboard from EditorClient
https://bugs.webkit.org/show_bug.cgi?id=121464
Summary
Remove unused function didSetSelectionTypesForPasteboard from EditorClient
Enrica Casucci
Reported
2013-09-16 18:04:46 PDT
The only existing implementation is for WebKit on Mac which is calling a private delegate which is also unused.
Attachments
Patch
(17.69 KB, patch)
2013-09-16 18:33 PDT
,
Enrica Casucci
darin
: review+
webkit-ews
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Enrica Casucci
Comment 1
2013-09-16 18:33:07 PDT
Created
attachment 211851
[details]
Patch
Early Warning System Bot
Comment 2
2013-09-16 18:40:00 PDT
Comment on
attachment 211851
[details]
Patch
Attachment 211851
[details]
did not pass qt-ews (qt): Output:
http://webkit-queues.appspot.com/results/1813268
EFL EWS Bot
Comment 3
2013-09-16 20:08:22 PDT
Comment on
attachment 211851
[details]
Patch
Attachment 211851
[details]
did not pass efl-ews (efl): Output:
http://webkit-queues.appspot.com/results/1833059
kov's GTK+ EWS bot
Comment 4
2013-09-16 22:51:40 PDT
Comment on
attachment 211851
[details]
Patch
Attachment 211851
[details]
did not pass gtk-ews (gtk): Output:
http://webkit-queues.appspot.com/results/1907128
Early Warning System Bot
Comment 5
2013-09-17 02:26:14 PDT
Comment on
attachment 211851
[details]
Patch
Attachment 211851
[details]
did not pass qt-wk2-ews (qt-wk2): Output:
http://webkit-queues.appspot.com/results/1869348
Darin Adler
Comment 6
2013-09-17 09:20:39 PDT
One of the errors: CMakeFiles/WebKit.dir/efl/WebCoreSupport/EditorClientEfl.cpp.o:(.data.rel.ro._ZTVN7WebCore15EditorClientEflE[_ZTVN7WebCore15EditorClientEflE]+0x1a0): undefined reference to `WebCore::EditorClientEfl::didSetSelectionTypesForPasteboard()' Need to do a bit more grepping and deleting I think.
Enrica Casucci
Comment 7
2013-09-17 10:19:30 PDT
I fixed the builds for qt, gtk and elf. Committed revision 155971.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug