Bug 121464 - Remove unused function didSetSelectionTypesForPasteboard from EditorClient
Summary: Remove unused function didSetSelectionTypesForPasteboard from EditorClient
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: All Unspecified
: P2 Normal
Assignee: Enrica Casucci
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-16 18:04 PDT by Enrica Casucci
Modified: 2013-09-17 10:19 PDT (History)
6 users (show)

See Also:

Attachments
Patch (17.69 KB, patch)
2013-09-16 18:33 PDT, Enrica Casucci 		darin: review+
webkit-ews: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Enrica Casucci 2013-09-16 18:04:46 PDT 
The only existing implementation is for WebKit on Mac which is calling a private delegate which is also unused.
Comment 1 Enrica Casucci 2013-09-16 18:33:07 PDT 
Created attachment 211851 [details]
Patch
Comment 2 Early Warning System Bot 2013-09-16 18:40:00 PDT 
Comment on attachment 211851 [details]
Patch

Attachment 211851 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1813268
Comment 3 EFL EWS Bot 2013-09-16 20:08:22 PDT 
Comment on attachment 211851 [details]
Patch

Attachment 211851 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/1833059
Comment 4 kov's GTK+ EWS bot 2013-09-16 22:51:40 PDT 
Comment on attachment 211851 [details]
Patch

Attachment 211851 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/1907128
Comment 5 Early Warning System Bot 2013-09-17 02:26:14 PDT 
Comment on attachment 211851 [details]
Patch

Attachment 211851 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1869348
Comment 6 Darin Adler 2013-09-17 09:20:39 PDT 
One of the errors:

CMakeFiles/WebKit.dir/efl/WebCoreSupport/EditorClientEfl.cpp.o:(.data.rel.ro._ZTVN7WebCore15EditorClientEflE[_ZTVN7WebCore15EditorClientEflE]+0x1a0): 
undefined reference to `WebCore::EditorClientEfl::didSetSelectionTypesForPasteboard()'

Need to do a bit more grepping and deleting I think.
Comment 7 Enrica Casucci 2013-09-17 10:19:30 PDT 
I fixed the builds for qt, gtk and elf.
Committed revision 155971.