Bug 121461 - Make InspectorTimelineAgent use an enum for the record type instead of a string.
Summary: Make InspectorTimelineAgent use an enum for the record type instead of a string.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-16 16:46 PDT by Timothy Hatcher
Modified: 2013-09-16 18:30 PDT (History)
3 users (show)

See Also:

Attachments
Patch (32.54 KB, patch)
2013-09-16 16:47 PDT, Timothy Hatcher 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2013-09-16 16:46:07 PDT 
Make InspectorTimelineAgent use an enum for the record type instead of a string.
Comment 1 Timothy Hatcher 2013-09-16 16:47:18 PDT 
Created attachment 211843 [details]
Patch
Comment 2 WebKit Commit Bot 2013-09-16 16:49:22 PDT 
Attachment 211843 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/inspector/Inspector.json', u'Source/WebCore/inspector/InspectorTimelineAgent.cpp', u'Source/WebCore/inspector/InspectorTimelineAgent.h', u'Source/WebInspectorUI/ChangeLog', u'Source/WebInspectorUI/UserInterface/InspectorBackendCommands.js', u'Source/WebInspectorUI/UserInterface/Legacy/6.0/InspectorBackendCommands.js', u'Source/WebInspectorUI/UserInterface/TimelineManager.js', u'Source/WebInspectorUI/Versions/Inspector-iOS-6.0.json']" exit_code: 1
Source/WebCore/inspector/InspectorTimelineAgent.h:65:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Joseph Pecoraro 2013-09-16 16:52:03 PDT 
Comment on attachment 211843 [details]
Patch

r=me, nice!
Comment 4 WebKit Commit Bot 2013-09-16 18:30:30 PDT 
Comment on attachment 211843 [details]
Patch

Clearing flags on attachment: 211843

Committed r155924: <http://trac.webkit.org/changeset/155924>
Comment 5 WebKit Commit Bot 2013-09-16 18:30:32 PDT 
All reviewed patches have been landed.  Closing bug.