Bug 121460 - Disable OS X's unprefixed debug macro
Summary: Disable OS X's unprefixed debug macro
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-16 16:21 PDT by Benjamin Poulain
Modified: 2013-09-16 16:48 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.15 KB, patch)
2013-09-16 16:22 PDT, Benjamin Poulain
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2013-09-16 16:21:46 PDT
Disable OS X's unprefixed debug macro
Comment 1 Benjamin Poulain 2013-09-16 16:22:24 PDT
Created attachment 211841 [details]
Patch
Comment 2 Anders Carlsson 2013-09-16 16:23:33 PDT
Comment on attachment 211841 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=211841&action=review

> Source/WTF/wtf/Platform.h:531
> +#define __ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORES 0

I think you should add the same comment in the change log above this #define as well.
Comment 3 Benjamin Poulain 2013-09-16 16:29:31 PDT
Committed r155910: <http://trac.webkit.org/changeset/155910>
Comment 4 Benjamin Poulain 2013-09-16 16:38:10 PDT
Committed r155912: <http://trac.webkit.org/changeset/155912>
Comment 5 Darin Adler 2013-09-16 16:48:42 PDT
Comment on attachment 211841 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=211841&action=review

> Source/WTF/ChangeLog:8
> +        * wtf/Platform.h: OS X defines a serie of platform macros for debugging.

Missing trailing s in "series".