WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 121460
Disable OS X's unprefixed debug macro
https://bugs.webkit.org/show_bug.cgi?id=121460
Summary
Disable OS X's unprefixed debug macro
Benjamin Poulain
Reported
2013-09-16 16:21:46 PDT
Disable OS X's unprefixed debug macro
Attachments
Patch
(1.15 KB, patch)
2013-09-16 16:22 PDT
,
Benjamin Poulain
andersca
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Benjamin Poulain
Comment 1
2013-09-16 16:22:24 PDT
Created
attachment 211841
[details]
Patch
Anders Carlsson
Comment 2
2013-09-16 16:23:33 PDT
Comment on
attachment 211841
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=211841&action=review
> Source/WTF/wtf/Platform.h:531 > +#define __ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORES 0
I think you should add the same comment in the change log above this #define as well.
Benjamin Poulain
Comment 3
2013-09-16 16:29:31 PDT
Committed
r155910
: <
http://trac.webkit.org/changeset/155910
>
Benjamin Poulain
Comment 4
2013-09-16 16:38:10 PDT
Committed
r155912
: <
http://trac.webkit.org/changeset/155912
>
Darin Adler
Comment 5
2013-09-16 16:48:42 PDT
Comment on
attachment 211841
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=211841&action=review
> Source/WTF/ChangeLog:8 > + * wtf/Platform.h: OS X defines a serie of platform macros for debugging.
Missing trailing s in "series".
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug