Rather than "thread" logic like isMainThread we should use RunLoop logic.
Created attachment 211838 [details] [PATCH] Proposed Fix
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment on attachment 211838 [details] [PATCH] Proposed Fix Rejecting attachment 211838 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 211838, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!. Full output: http://webkit-queues.appspot.com/results/1869241
Comment on attachment 211838 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=211838&action=review > Source/WebKit2/UIProcess/API/mac/WKPrintingView.mm:126 > + ASSERT(RunLoop::isMain()); // This funciton calls the client, which should only be done on main thread. funciton!
Committed <http://trac.webkit.org/changeset/155911>.