Bug 121459 - Add RunLoop::isMain and use it in WebKit2
Summary: Add RunLoop::isMain and use it in WebKit2
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2013-09-16 15:35 PDT by Joseph Pecoraro
Modified: 2013-09-16 16:31 PDT (History)
7 users (show)

See Also:

[PATCH] Proposed Fix (12.73 KB, patch)
2013-09-16 15:37 PDT, Joseph Pecoraro
andersca: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2013-09-16 15:35:59 PDT
Rather than "thread" logic like isMainThread we should use RunLoop logic.
Comment 1 Joseph Pecoraro 2013-09-16 15:37:58 PDT
Created attachment 211838 [details]
[PATCH] Proposed Fix
Comment 2 WebKit Commit Bot 2013-09-16 15:40:11 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 WebKit Commit Bot 2013-09-16 15:46:13 PDT
Comment on attachment 211838 [details]
[PATCH] Proposed Fix

Rejecting attachment 211838 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 211838, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.

Full output: http://webkit-queues.appspot.com/results/1869241
Comment 4 Darin Adler 2013-09-16 15:49:48 PDT
Comment on attachment 211838 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=211838&action=review

> Source/WebKit2/UIProcess/API/mac/WKPrintingView.mm:126
> +    ASSERT(RunLoop::isMain()); // This funciton calls the client, which should only be done on main thread.

Comment 5 Joseph Pecoraro 2013-09-16 16:31:50 PDT
Committed <http://trac.webkit.org/changeset/155911>.