RESOLVED INVALID 121457
[Windows] Reduce use of static objects with destructors 
https://bugs.webkit.org/show_bug.cgi?id=121457
Summary [Windows] Reduce use of static objects with destructors
Brent Fulgham
Reported Monday, September 16, 2013 11:13:41 PM UTC
Switch static objects (where possible) in the WebKit layer to use the DEFINE_STATIC_LOCAL construct. This will reduce the amount of time we spend executing destructors when terminating processes.
Attachments
Patch (16.93 KB, patch)
2013-09-16 15:30 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 Monday, September 16, 2013 11:30:24 PM UTC
Created attachment 211837 [details] Patch
Darin Adler
Comment 2 Monday, September 16, 2013 11:32:33 PM UTC
Comment on attachment 211837 [details] Patch We are trying to phase out DEFINE_STATIC_LOCAL from the project. You should be able to achieve similar results with NeverDestroyed.
WebKit Commit Bot
Comment 3 Monday, September 16, 2013 11:33:28 PM UTC
Attachment 211837 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/win/AccessibleBase.cpp', u'Source/WebKit/win/ChangeLog', u'Source/WebKit/win/WebCoreSupport/WebEditorClient.cpp', u'Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp', u'Source/WebKit/win/WebDatabaseManager.cpp', u'Source/WebKit/win/WebHistoryItem.cpp', u'Source/WebKit/win/WebIconDatabase.cpp', u'Source/WebKit/win/WebPreferences.cpp', u'Source/WebKit/win/WebURLProtectionSpace.cpp', u'Source/WebKit/win/WebView.cpp']" exit_code: 1 Source/WebKit/win/WebURLProtectionSpace.cpp:147: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/win/WebURLProtectionSpace.cpp:171: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 2 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 4 Tuesday, September 17, 2013 4:27:14 PM UTC
I don't think any of these need to be static.
Brent Fulgham
Comment 5 Tuesday, January 21, 2014 7:41:16 PM UTC
We're going in a different direction for this...
Note You need to log in before you can comment on or make changes to this bug.