WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
121450
MessageQueue should use a Deque of OwnPtrs
https://bugs.webkit.org/show_bug.cgi?id=121450
Summary
MessageQueue should use a Deque of OwnPtrs
Anders Carlsson
Reported
2013-09-16 13:10:57 PDT
MessageQueue should use a Deque of OwnPtrs
Attachments
Patch
(10.96 KB, patch)
2013-09-16 13:46 PDT
,
Anders Carlsson
kling
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Anders Carlsson
Comment 1
2013-09-16 13:46:47 PDT
Created
attachment 211828
[details]
Patch
Andreas Kling
Comment 2
2013-09-16 14:02:01 PDT
Comment on
attachment 211828
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=211828&action=review
> Source/WTF/wtf/MessageQueue.h:197 > + // FIXME: I think the predicate here should really take a const DataType& > + // instead of a const OwnPtr<DataType>&.
I agree with this FIXME. Yikes.
Anders Carlsson
Comment 3
2013-09-16 14:08:55 PDT
Committed
r155900
: <
http://trac.webkit.org/changeset/155900
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug