Bug 121448 - Fix creation of embedded JS and CSS files on cmake based ports.
Summary: Fix creation of embedded JS and CSS files on cmake based ports.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hugo Parente Lima
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-16 12:29 PDT by Hugo Parente Lima
Modified: 2013-09-16 14:45 PDT (History)
4 users (show)

See Also:

Attachments
Patch (4.66 KB, patch)
2013-09-16 12:40 PDT, Hugo Parente Lima 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hugo Parente Lima 2013-09-16 12:29:23 PDT 
After r155790 JavaScript and CSS files aren't embedded correctly due to a fail on js/css minimization process.

CMake expands the macros to:

/usr/bin/python2 WEBKITDIR/Source/WebCore/inspector/Scripts/cssmin.py "<WEBKITDIR/Source/WebCore/xml/XMLViewer.css" > WEBKITDIR/WebKitBuild/Release/DerivedSources/WebCore/XMLViewer.min.css

instead of:

/usr/bin/python2 WEBKITDIR/Source/WebCore/inspector/Scripts/cssmin.py < WEBKITDIR/Source/WebCore/xml/XMLViewer.css > WEBKITDIR/WebKitBuild/Release/DerivedSources/WebCore/XMLViewer.min.css
Comment 1 Hugo Parente Lima 2013-09-16 12:40:51 PDT 
Created attachment 211821 [details]
Patch
Comment 2 Joseph Pecoraro 2013-09-16 12:45:41 PDT 
Comment on attachment 211821 [details]
Patch

r=me, thanks!
Comment 3 WebKit Commit Bot 2013-09-16 14:45:10 PDT 
Comment on attachment 211821 [details]
Patch

Clearing flags on attachment: 211821

Committed r155903: <http://trac.webkit.org/changeset/155903>
Comment 4 WebKit Commit Bot 2013-09-16 14:45:12 PDT 
All reviewed patches have been landed.  Closing bug.