Bug 121446 - WTF::Deque should work with move only types
Summary: WTF::Deque should work with move only types
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-16 12:20 PDT by Anders Carlsson
Modified: 2013-09-16 13:38 PDT (History)
4 users (show)

See Also:

Attachments
Patch (6.99 KB, patch)
2013-09-16 12:24 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (6.36 KB, patch)
2013-09-16 12:34 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (6.36 KB, patch)
2013-09-16 12:41 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2013-09-16 12:20:55 PDT 
WTF::Deque should work with move only types
Comment 1 Anders Carlsson 2013-09-16 12:24:06 PDT 
Created attachment 211818 [details]
Patch
Comment 2 WebKit Commit Bot 2013-09-16 12:25:58 PDT 
Attachment 211818 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/Deque.h', u'Tools/ChangeLog', u'Tools/TestWebKitAPI/Tests/WTF/Deque.cpp']" exit_code: 1
Source/WTF/wtf/Deque.h:81:  Missing spaces around &&  [whitespace/operators] [3]
Source/WTF/wtf/Deque.h:82:  Missing spaces around &&  [whitespace/operators] [3]
Total errors found: 2 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Early Warning System Bot 2013-09-16 12:34:05 PDT 
Comment on attachment 211818 [details]
Patch

Attachment 211818 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1916497
Comment 4 Anders Carlsson 2013-09-16 12:34:49 PDT 
Created attachment 211820 [details]
Patch
Comment 5 WebKit Commit Bot 2013-09-16 12:37:08 PDT 
Attachment 211820 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/Deque.h', u'Tools/ChangeLog', u'Tools/TestWebKitAPI/Tests/WTF/Deque.cpp']" exit_code: 1
Source/WTF/wtf/Deque.h:81:  Missing spaces around &&  [whitespace/operators] [3]
Source/WTF/wtf/Deque.h:82:  Missing spaces around &&  [whitespace/operators] [3]
Total errors found: 2 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Anders Carlsson 2013-09-16 12:41:12 PDT 
Created attachment 211822 [details]
Patch
Comment 7 WebKit Commit Bot 2013-09-16 12:44:12 PDT 
Attachment 211822 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/Deque.h', u'Tools/ChangeLog', u'Tools/TestWebKitAPI/Tests/WTF/Deque.cpp']" exit_code: 1
Source/WTF/wtf/Deque.h:81:  Missing spaces around &&  [whitespace/operators] [3]
Source/WTF/wtf/Deque.h:82:  Missing spaces around &&  [whitespace/operators] [3]
Total errors found: 2 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 WebKit Commit Bot 2013-09-16 13:38:15 PDT 
Comment on attachment 211822 [details]
Patch

Clearing flags on attachment: 211822

Committed r155898: <http://trac.webkit.org/changeset/155898>
Comment 9 WebKit Commit Bot 2013-09-16 13:38:17 PDT 
All reviewed patches have been landed.  Closing bug.