Bug 121442 - AX: Mac AXARIABusy should be AXElementBusy (not ARIA specific)
Summary: AX: Mac AXARIABusy should be AXElementBusy (not ARIA specific)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.8
: P2 Normal
Assignee: Samuel White
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-09-16 11:00 PDT by James Craig
Modified: 2013-09-17 16:07 PDT (History)
9 users (show)

See Also:


Attachments
Patch. (44.99 KB, patch)
2013-09-17 11:55 PDT, Samuel White
no flags Details | Formatted Diff | Diff
Patch. (45.03 KB, patch)
2013-09-17 14:15 PDT, Samuel White
cfleizach: review+
Details | Formatted Diff | Diff
Patch. (45.03 KB, patch)
2013-09-17 15:12 PDT, Samuel White
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Craig 2013-09-16 11:00:10 PDT
AX: Mac AXARIABusy should not be ARIA-specific; perhaps AXBusy? Unlike the live region properties, the general concept of an element in a busy state (while loading, initializing, etc.) is not specific to ARIA, so the API property should not reference ARIA. I'm leaning toward AXBusy, though AXElementBusy might be a little more precise.
Comment 1 Radar WebKit Bug Importer 2013-09-16 11:01:17 PDT
<rdar://problem/15000561>
Comment 2 Samuel White 2013-09-17 11:55:51 PDT
Created attachment 211928 [details]
Patch.

Renamed AXARIABusy attribute to AXElementBusy and updated layout tests.
Comment 3 chris fleizach 2013-09-17 13:36:20 PDT
Comment on attachment 211928 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=211928&action=review

> LayoutTests/platform/mac/accessibility/aria-liveregions-attributes-expected.txt:18
> +FAIL accessibilityController.focusedElement.isAttributeSupported('AXElementBusy') should be false. Was true.

why is this a fail?
i know it was there before but it seems wrong
Comment 4 Samuel White 2013-09-17 14:15:45 PDT
Created attachment 211938 [details]
Patch.
Comment 5 Samuel White 2013-09-17 14:21:04 PDT
(In reply to comment #3)
> (From update of attachment 211928 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=211928&action=review
> 
> > LayoutTests/platform/mac/accessibility/aria-liveregions-attributes-expected.txt:18
> > +FAIL accessibilityController.focusedElement.isAttributeSupported('AXElementBusy') should be false. Was true.
> 
> why is this a fail?
> i know it was there before but it seems wrong

Agreed, this was definitely wrong. I suspect this was leftover from a time when ONLY live regions supported aria-busy (AXARIABusy at the platform level).

Comment evidence (line 1016 of WebAccessibilityObjectWrapperMac.mm):

// All objects should expose the ARIA busy attribute (ARIA 1.1 with ISSUE-538).
Comment 6 chris fleizach 2013-09-17 14:45:42 PDT
(In reply to comment #5)
> (In reply to comment #3)
> > (From update of attachment 211928 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=211928&action=review
> > 
> > > LayoutTests/platform/mac/accessibility/aria-liveregions-attributes-expected.txt:18
> > > +FAIL accessibilityController.focusedElement.isAttributeSupported('AXElementBusy') should be false. Was true.
> > 
> > why is this a fail?
> > i know it was there before but it seems wrong
> 
> Agreed, this was definitely wrong. I suspect this was leftover from a time when ONLY live regions supported aria-busy (AXARIABusy at the platform level).
> 
> Comment evidence (line 1016 of WebAccessibilityObjectWrapperMac.mm):
> 
> // All objects should expose the ARIA busy attribute (ARIA 1.1 with ISSUE-538).

I guess we should change it to use shouldBeTrue then since it's supported on all elements
Comment 7 chris fleizach 2013-09-17 14:46:30 PDT
Comment on attachment 211938 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=211938&action=review

> LayoutTests/ChangeLog:3
> +        AX: Mac AXARIABusy should not be ARIA-specific; perhaps AXBusy?

let's update the bug title so that it reflects what we did
Comment 8 Samuel White 2013-09-17 15:12:33 PDT
Created attachment 211948 [details]
Patch.

Patch with updated title.
Comment 9 WebKit Commit Bot 2013-09-17 16:07:03 PDT
Comment on attachment 211948 [details]
Patch.

Clearing flags on attachment: 211948

Committed r156011: <http://trac.webkit.org/changeset/156011>
Comment 10 WebKit Commit Bot 2013-09-17 16:07:07 PDT
All reviewed patches have been landed.  Closing bug.