Bug 121433 - [GTK][EFL] Add ResourceError::internalError() after r138387
Summary: [GTK][EFL] Add ResourceError::internalError() after r138387
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Csaba Osztrogonác
URL:
Keywords:
Depends on:
Blocks: 110141
  Show dependency tree / graph
 
Reported: 2013-09-16 08:21 PDT by Csaba Osztrogonác
Modified: 2013-09-17 02:46 PDT (History)
10 users (show)

See Also:

Attachments
Patch (2.89 KB, patch)
2013-09-16 08:27 PDT, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
Patch (2.99 KB, patch)
2013-09-17 01:34 PDT, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2013-09-16 08:21:30 PDT 
http://trac.webkit.org/changeset/138387 added the new ResourceError::internalError(), 
but for Mac only. We need it for GTK and EFL too.
Comment 1 Csaba Osztrogonác 2013-09-16 08:27:35 PDT 
Created attachment 211788 [details]
Patch

I fixed the GTK implementation as Kwang Yul Seo noticed in https://bugs.webkit.org/show_bug.cgi?id=110141#c13
Comment 2 Csaba Osztrogonác 2013-09-17 01:34:12 PDT 
Created attachment 211873 [details]
Patch

glib/gi18n-lib.h added to fix the GTK build.
Comment 3 Chris Dumez 2013-09-17 02:14:22 PDT 
Comment on attachment 211873 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=211873&action=review

> Source/WebKit2/WebProcess/WebCoreSupport/efl/WebErrorsEfl.cpp:75
> +WebCore::ResourceError internalError(const WebCore::KURL& url)

Shouldn't we protect this with #if ENABLE(NETWORK_PROCESS) ?

> Source/WebKit2/WebProcess/WebCoreSupport/gtk/WebErrorsGtk.cpp:78
> +WebCore::ResourceError internalError(const WebCore::KURL& url)

Ditto.
Comment 4 Csaba Osztrogonác 2013-09-17 02:23:05 PDT 
Comment on attachment 211873 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=211873&action=review

>> Source/WebKit2/WebProcess/WebCoreSupport/efl/WebErrorsEfl.cpp:75
>> +WebCore::ResourceError internalError(const WebCore::KURL& url)
> 
> Shouldn't we protect this with #if ENABLE(NETWORK_PROCESS) ?

internalError() is called from only ENABLE(NETWORK_PROCESS) blocks, but it builds now 
with !ENABLE(NETWORK_PROCESS). I don't think if we should add guards not to have 
unreachable code. It is the job of the linker to get rid these unused functions.
Comment 5 Chris Dumez 2013-09-17 02:26:58 PDT 
Comment on attachment 211873 [details]
Patch

I don't really mind either way so r+. There is no guard in WebErrors.h anyway.
Comment 6 Csaba Osztrogonác 2013-09-17 02:46:40 PDT 
Comment on attachment 211873 [details]
Patch

Clearing flags on attachment: 211873

Committed r155942: <http://trac.webkit.org/changeset/155942>
Comment 7 Csaba Osztrogonác 2013-09-17 02:46:46 PDT 
All reviewed patches have been landed.  Closing bug.