Bug 121420 - [Win] Compile errors in WebCore derived sources.
Summary: [Win] Compile errors in WebCore derived sources.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-16 03:41 PDT by peavo
Modified: 2013-09-16 09:17 PDT (History)
15 users (show)

See Also:


Attachments
Patch (2.86 KB, patch)
2013-09-16 03:50 PDT, peavo
no flags Details | Formatted Diff | Diff
Patch (2.77 KB, patch)
2013-09-16 07:36 PDT, peavo
bfulgham: review+
peavo: commit-queue?
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description peavo 2013-09-16 03:41:16 PDT
There's a few compile errors in WebCore, e.g:

WebCore\DerivedSources\HTMLNames.cpp(4313): error C2440: 'reinterpret_cast' : cannot convert from 'const WebCore::QualifiedName *' to 'WebCore::QualifiedName *' Conversion loses qualifiers 

WebCore\DerivedSources\MathMLNames.cpp(721): error C2440: 'initializing' : cannot convert from 'const WebCore::QualifiedName *' to 'void *' Conversion loses qualifiers
Comment 1 peavo 2013-09-16 03:50:09 PDT
Created attachment 211756 [details]
Patch
Comment 2 Early Warning System Bot 2013-09-16 03:58:38 PDT
Comment on attachment 211756 [details]
Patch

Attachment 211756 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1865012
Comment 3 Early Warning System Bot 2013-09-16 04:00:33 PDT
Comment on attachment 211756 [details]
Patch

Attachment 211756 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1884175
Comment 4 EFL EWS Bot 2013-09-16 04:03:55 PDT
Comment on attachment 211756 [details]
Patch

Attachment 211756 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1919005
Comment 5 Build Bot 2013-09-16 04:17:14 PDT
Comment on attachment 211756 [details]
Patch

Attachment 211756 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1835104
Comment 6 EFL EWS Bot 2013-09-16 04:34:33 PDT
Comment on attachment 211756 [details]
Patch

Attachment 211756 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/1884182
Comment 7 Build Bot 2013-09-16 04:36:31 PDT
Comment on attachment 211756 [details]
Patch

Attachment 211756 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1865015
Comment 8 kov's GTK+ EWS bot 2013-09-16 04:40:20 PDT
Comment on attachment 211756 [details]
Patch

Attachment 211756 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/1852213
Comment 9 peavo 2013-09-16 07:36:43 PDT
Created attachment 211782 [details]
Patch
Comment 10 Chris Dumez 2013-09-16 07:39:28 PDT
Comment on attachment 211782 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=211782&action=review

> Source/WebCore/dom/make_names.pl:755
> +    print(F "    new (NotNull, (void*)&${lowerNamespace}NamespaceURI) AtomicString(${lowerNamespace}NS);\n");

We usually avoid C-Style casts in the code.

> Source/WebCore/dom/make_names.pl:866
> +        print F "        { (void*)&$name$shortCamelType, *${name}Impl },\n";

Ditto.
Comment 11 Brent Fulgham 2013-09-16 08:58:15 PDT
Comment on attachment 211782 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=211782&action=review

>> Source/WebCore/dom/make_names.pl:755
>> +    print(F "    new (NotNull, (void*)&${lowerNamespace}NamespaceURI) AtomicString(${lowerNamespace}NS);\n");
> 
> We usually avoid C-Style casts in the code.

When SKIP_STATIC_CONSTRUCTORS_ON_GCC is defined, the types of these globals are non-const. For all other platforms, they are const.  This requires a combination of static_cast and const_cast, but it is dependent on the setting of this variable.

I think in this case, the old fashioned C-style cast is the most concise way of dealing with this.

>> Source/WebCore/dom/make_names.pl:866
>> +        print F "        { (void*)&$name$shortCamelType, *${name}Impl },\n";
> 
> Ditto.

Idem.
Comment 12 Brent Fulgham 2013-09-16 09:02:58 PDT
This build failure was introduced in http://trac.webkit.org/changeset/155801.

Darin reverted part of the change back in http://trac.webkit.org/changeset/155834/trunk/Source/WebCore/dom/make_names.pl.

This change is in keeping with Darin's adjustment.
Comment 13 Brent Fulgham 2013-09-16 09:03:26 PDT
Comment on attachment 211782 [details]
Patch

r=me
Comment 14 Brent Fulgham 2013-09-16 09:17:58 PDT
Committed r155868: <http://trac.webkit.org/changeset/155868>