Bug 121420 – [Win] Compile errors in WebCore derived sources.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

There's a few compile errors in WebCore, e.g:

WebCore\DerivedSources\HTMLNames.cpp(4313): error C2440: 'reinterpret_cast' : cannot convert from 'const WebCore::QualifiedName *' to 'WebCore::QualifiedName *' Conversion loses qualifiers 

WebCore\DerivedSources\MathMLNames.cpp(721): error C2440: 'initializing' : cannot convert from 'const WebCore::QualifiedName *' to 'void *' Conversion loses qualifiers

Created attachment 211756 [details]
Patch

[Early Warning System Bot]

Comment on attachment 211756 [details]
Patch

Attachment 211756 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1865012

[Early Warning System Bot]

Comment on attachment 211756 [details]
Patch

Attachment 211756 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1884175

[EFL EWS Bot]

Comment on attachment 211756 [details]
Patch

Attachment 211756 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1919005

[Build Bot]

Comment on attachment 211756 [details]
Patch

Attachment 211756 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1835104

[EFL EWS Bot]

Comment on attachment 211756 [details]
Patch

Attachment 211756 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/1884182

[Build Bot]

Comment on attachment 211756 [details]
Patch

Attachment 211756 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1865015

[kov's GTK+ EWS bot]

Comment on attachment 211756 [details]
Patch

Attachment 211756 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/1852213

Created attachment 211782 [details]
Patch

[Chris Dumez]

Comment on attachment 211782 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=211782&action=review

> Source/WebCore/dom/make_names.pl:755
> +    print(F "    new (NotNull, (void*)&${lowerNamespace}NamespaceURI) AtomicString(${lowerNamespace}NS);\n");

We usually avoid C-Style casts in the code.

> Source/WebCore/dom/make_names.pl:866
> +        print F "        { (void*)&$name$shortCamelType, *${name}Impl },\n";

Ditto.

[Brent Fulgham]

Comment on attachment 211782 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=211782&action=review

>> Source/WebCore/dom/make_names.pl:755
>> +    print(F "    new (NotNull, (void*)&${lowerNamespace}NamespaceURI) AtomicString(${lowerNamespace}NS);\n");
> 
> We usually avoid C-Style casts in the code.

When SKIP_STATIC_CONSTRUCTORS_ON_GCC is defined, the types of these globals are non-const. For all other platforms, they are const.  This requires a combination of static_cast and const_cast, but it is dependent on the setting of this variable.

I think in this case, the old fashioned C-style cast is the most concise way of dealing with this.

>> Source/WebCore/dom/make_names.pl:866
>> +        print F "        { (void*)&$name$shortCamelType, *${name}Impl },\n";
> 
> Ditto.

Idem.

[Brent Fulgham]

This build failure was introduced in http://trac.webkit.org/changeset/155801.

Darin reverted part of the change back in http://trac.webkit.org/changeset/155834/trunk/Source/WebCore/dom/make_names.pl.

This change is in keeping with Darin's adjustment.

[Brent Fulgham]

Comment on attachment 211782 [details]
Patch

r=me

[Brent Fulgham]

Committed r155868: <http://trac.webkit.org/changeset/155868>