RESOLVED FIXED 121418
Devirtualize Document::detach(). 
https://bugs.webkit.org/show_bug.cgi?id=121418
Summary Devirtualize Document::detach().
Andreas Kling
Reported 2013-09-16 03:18:06 PDT
Devirtualize Document::detach().
Attachments
Patch (2.97 KB, patch)
2013-09-16 03:18 PDT, Andreas Kling 		koivisto: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2013-09-16 03:18:31 PDT
Created attachment 211750 [details] Patch
Antti Koivisto
Comment 2 2013-09-16 03:50:06 PDT
Comment on attachment 211750 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=211750&action=review > Source/WebCore/dom/Document.h:543 > + void detach(); It would be nice to rename this to something more informative like detachRenderTree().
Andreas Kling
Comment 3 2013-09-16 03:54:33 PDT
(In reply to comment #2) > (From update of attachment 211750 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=211750&action=review > > > Source/WebCore/dom/Document.h:543 > > + void detach(); > > It would be nice to rename this to something more informative like detachRenderTree(). I like the idea, but the problem right now is that Document::detach() is an irreversible operation that also detaches from the Frame.
Andreas Kling
Comment 4 2013-09-16 04:43:54 PDT
Committed r155849: <http://trac.webkit.org/changeset/155849>
Lucas Forschler
Comment 5 2019-02-06 09:04:11 PST
Mass moving XML DOM bugs to the "DOM" Component.
Note You need to log in before you can comment on or make changes to this bug.