Bug 121418 - Devirtualize Document::detach().
Summary: Devirtualize Document::detach().
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-16 03:18 PDT by Andreas Kling
Modified: 2019-02-06 09:04 PST (History)
5 users (show)

See Also:

Attachments
Patch (2.97 KB, patch)
2013-09-16 03:18 PDT, Andreas Kling 		koivisto: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-09-16 03:18:06 PDT 
Devirtualize Document::detach().
Comment 1 Andreas Kling 2013-09-16 03:18:31 PDT 
Created attachment 211750 [details]
Patch
Comment 2 Antti Koivisto 2013-09-16 03:50:06 PDT 
Comment on attachment 211750 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=211750&action=review

> Source/WebCore/dom/Document.h:543
> +    void detach();

It would be nice to rename this to something more informative like detachRenderTree().
Comment 3 Andreas Kling 2013-09-16 03:54:33 PDT 
(In reply to comment #2)
> (From update of attachment 211750 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=211750&action=review
> 
> > Source/WebCore/dom/Document.h:543
> > +    void detach();
> 
> It would be nice to rename this to something more informative like detachRenderTree().

I like the idea, but the problem right now is that Document::detach() is an irreversible operation that also detaches from the Frame.
Comment 4 Andreas Kling 2013-09-16 04:43:54 PDT 
Committed r155849: <http://trac.webkit.org/changeset/155849>
Comment 5 Lucas Forschler 2019-02-06 09:04:11 PST 
Mass moving XML DOM bugs to the "DOM" Component.