Bug 121412 – [sh4] Handle subp opcode with 3 operands and bpbeq opcode in LLINT

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Julien Brianceau]

Handle subp opcode with 3 operands in sh4 LLINT backend.

offlineasm: Parsing /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/llint/LowLevelInterpreter.asm and LLIntOffsetsExtractor and creating assembly file generated/LLIntAssembly.h.
offlineasm: Including file /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/llint/LowLevelInterpreter64.asm
offlineasm: Including file /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm
/local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/offlineasm/sh4.rb:573:in `lowerSH4': subp with 3 operands is not handled yetAt /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/llint/LowLevelInterpreter.asm:376 (RuntimeError)
	from /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/offlineasm/backends.rb:67:in `lower'
	from /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/offlineasm/backends.rb:119:in `block in lower'
	from /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/offlineasm/backends.rb:117:in `each'
	from /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/offlineasm/backends.rb:117:in `lower'
	from /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/offlineasm/asm.rb:271:in `block (5 levels) in <main>'
	from /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/offlineasm/asm.rb:65:in `inAsm'
	from /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/offlineasm/asm.rb:270:in `block (4 levels) in <main>'
	from /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/offlineasm/settings.rb:182:in `emitCodeInConfiguration'
	from /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/offlineasm/asm.rb:269:in `block (3 levels) in <main>'
	from /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/offlineasm/settings.rb:89:in `forSettings'
	from /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/offlineasm/asm.rb:265:in `block (2 levels) in <main>'
	from /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/offlineasm/asm.rb:261:in `each'
	from /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/offlineasm/asm.rb:261:in `block in <main>'
	from /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/offlineasm/asm.rb:252:in `open'
	from /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/offlineasm/asm.rb:252:in `<main>'
make[2]: *** [generated/./LLIntAssembly.h] Error 1

[Julien Brianceau]

Handle bpbeq opcode in sh4 LLINT backend.

offlineasm: Including file /local/jbriance/WebKit/buildbot-env/webkit-dfg/Source/JavaScriptCore/llint/LowLevelInterpreter64.asm
offlineasm: Including file /local/jbriance/WebKit/buildbot-env/webkit-dfg/Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm
/local/jbriance/WebKit/buildbot-env/webkit-dfg/Source/JavaScriptCore/offlineasm/ast.rb:829:in `lowerDefault': Unhandled opcode bpbeq at /local/jbriance/WebKit/buildbot-env/webkit-dfg/Source/JavaScriptCore/llint/LowLevelInterpreter.asm:377At /local/jbriance/WebKit/buildbot-env/webkit-dfg/Source/JavaScriptCore/llint/LowLevelInterpreter.asm:377 (RuntimeError)
	from /local/jbriance/WebKit/buildbot-env/webkit-dfg/Source/JavaScriptCore/offlineasm/sh4.rb:783:in `lowerSH4'
	from /local/jbriance/WebKit/buildbot-env/webkit-dfg/Source/JavaScriptCore/offlineasm/backends.rb:67:in `lower'
	from /local/jbriance/WebKit/buildbot-env/webkit-dfg/Source/JavaScriptCore/offlineasm/backends.rb:119:in `block in lower'
	from /local/jbriance/WebKit/buildbot-env/webkit-dfg/Source/JavaScriptCore/offlineasm/backends.rb:117:in `each'
	from /local/jbriance/WebKit/buildbot-env/webkit-dfg/Source/JavaScriptCore/offlineasm/backends.rb:117:in `lower'
	from /local/jbriance/WebKit/buildbot-env/webkit-dfg/Source/JavaScriptCore/offlineasm/asm.rb:271:in `block (5 levels) in <main>'
	from /local/jbriance/WebKit/buildbot-env/webkit-dfg/Source/JavaScriptCore/offlineasm/asm.rb:65:in `inAsm'
	from /local/jbriance/WebKit/buildbot-env/webkit-dfg/Source/JavaScriptCore/offlineasm/asm.rb:270:in `block (4 levels) in <main>'
	from /local/jbriance/WebKit/buildbot-env/webkit-dfg/Source/JavaScriptCore/offlineasm/settings.rb:182:in `emitCodeInConfiguration'
	from /local/jbriance/WebKit/buildbot-env/webkit-dfg/Source/JavaScriptCore/offlineasm/asm.rb:269:in `block (3 levels) in <main>'
	from /local/jbriance/WebKit/buildbot-env/webkit-dfg/Source/JavaScriptCore/offlineasm/settings.rb:89:in `forSettings'
	from /local/jbriance/WebKit/buildbot-env/webkit-dfg/Source/JavaScriptCore/offlineasm/asm.rb:265:in `block (2 levels) in <main>'
	from /local/jbriance/WebKit/buildbot-env/webkit-dfg/Source/JavaScriptCore/offlineasm/asm.rb:261:in `each'
	from /local/jbriance/WebKit/buildbot-env/webkit-dfg/Source/JavaScriptCore/offlineasm/asm.rb:261:in `block in <main>'
	from /local/jbriance/WebKit/buildbot-env/webkit-dfg/Source/JavaScriptCore/offlineasm/asm.rb:252:in `open'
	from /local/jbriance/WebKit/buildbot-env/webkit-dfg/Source/JavaScriptCore/offlineasm/asm.rb:252:in `<main>'
make[3]: *** [generated/./LLIntAssembly.h] Error 1

[Julien Brianceau]

Created attachment 211744 [details]
Handle subp opcode with 3 operands and bpbeq opcode in sh4 LLINT backend.

[Andreas Kling]

Comment on attachment 211744 [details]
Handle subp opcode with 3 operands and bpbeq opcode in sh4 LLINT backend.

rs=me

[WebKit Commit Bot]

Comment on attachment 211744 [details]
Handle subp opcode with 3 operands and bpbeq opcode in sh4 LLINT backend.

Clearing flags on attachment: 211744

Committed r155846: <http://trac.webkit.org/changeset/155846>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.