Bug 121412 - [sh4] Handle subp opcode with 3 operands and bpbeq opcode in LLINT
Summary: [sh4] Handle subp opcode with 3 operands and bpbeq opcode in LLINT
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-16 00:08 PDT by Julien Brianceau
Modified: 2013-09-16 02:04 PDT (History)
5 users (show)

See Also:


Attachments
Handle subp opcode with 3 operands and bpbeq opcode in sh4 LLINT backend. (2.46 KB, patch)
2013-09-16 00:56 PDT, Julien Brianceau
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Brianceau 2013-09-16 00:08:16 PDT
Handle subp opcode with 3 operands in sh4 LLINT backend.

offlineasm: Parsing /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/llint/LowLevelInterpreter.asm and LLIntOffsetsExtractor and creating assembly file generated/LLIntAssembly.h.
offlineasm: Including file /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/llint/LowLevelInterpreter64.asm
offlineasm: Including file /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm
/local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/offlineasm/sh4.rb:573:in `lowerSH4': subp with 3 operands is not handled yetAt /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/llint/LowLevelInterpreter.asm:376 (RuntimeError)
	from /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/offlineasm/backends.rb:67:in `lower'
	from /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/offlineasm/backends.rb:119:in `block in lower'
	from /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/offlineasm/backends.rb:117:in `each'
	from /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/offlineasm/backends.rb:117:in `lower'
	from /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/offlineasm/asm.rb:271:in `block (5 levels) in <main>'
	from /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/offlineasm/asm.rb:65:in `inAsm'
	from /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/offlineasm/asm.rb:270:in `block (4 levels) in <main>'
	from /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/offlineasm/settings.rb:182:in `emitCodeInConfiguration'
	from /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/offlineasm/asm.rb:269:in `block (3 levels) in <main>'
	from /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/offlineasm/settings.rb:89:in `forSettings'
	from /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/offlineasm/asm.rb:265:in `block (2 levels) in <main>'
	from /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/offlineasm/asm.rb:261:in `each'
	from /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/offlineasm/asm.rb:261:in `block in <main>'
	from /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/offlineasm/asm.rb:252:in `open'
	from /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/offlineasm/asm.rb:252:in `<main>'
make[2]: *** [generated/./LLIntAssembly.h] Error 1
Comment 1 Julien Brianceau 2013-09-16 00:40:26 PDT
Handle bpbeq opcode in sh4 LLINT backend.

offlineasm: Including file /local/jbriance/WebKit/buildbot-env/webkit-dfg/Source/JavaScriptCore/llint/LowLevelInterpreter64.asm
offlineasm: Including file /local/jbriance/WebKit/buildbot-env/webkit-dfg/Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm
/local/jbriance/WebKit/buildbot-env/webkit-dfg/Source/JavaScriptCore/offlineasm/ast.rb:829:in `lowerDefault': Unhandled opcode bpbeq at /local/jbriance/WebKit/buildbot-env/webkit-dfg/Source/JavaScriptCore/llint/LowLevelInterpreter.asm:377At /local/jbriance/WebKit/buildbot-env/webkit-dfg/Source/JavaScriptCore/llint/LowLevelInterpreter.asm:377 (RuntimeError)
	from /local/jbriance/WebKit/buildbot-env/webkit-dfg/Source/JavaScriptCore/offlineasm/sh4.rb:783:in `lowerSH4'
	from /local/jbriance/WebKit/buildbot-env/webkit-dfg/Source/JavaScriptCore/offlineasm/backends.rb:67:in `lower'
	from /local/jbriance/WebKit/buildbot-env/webkit-dfg/Source/JavaScriptCore/offlineasm/backends.rb:119:in `block in lower'
	from /local/jbriance/WebKit/buildbot-env/webkit-dfg/Source/JavaScriptCore/offlineasm/backends.rb:117:in `each'
	from /local/jbriance/WebKit/buildbot-env/webkit-dfg/Source/JavaScriptCore/offlineasm/backends.rb:117:in `lower'
	from /local/jbriance/WebKit/buildbot-env/webkit-dfg/Source/JavaScriptCore/offlineasm/asm.rb:271:in `block (5 levels) in <main>'
	from /local/jbriance/WebKit/buildbot-env/webkit-dfg/Source/JavaScriptCore/offlineasm/asm.rb:65:in `inAsm'
	from /local/jbriance/WebKit/buildbot-env/webkit-dfg/Source/JavaScriptCore/offlineasm/asm.rb:270:in `block (4 levels) in <main>'
	from /local/jbriance/WebKit/buildbot-env/webkit-dfg/Source/JavaScriptCore/offlineasm/settings.rb:182:in `emitCodeInConfiguration'
	from /local/jbriance/WebKit/buildbot-env/webkit-dfg/Source/JavaScriptCore/offlineasm/asm.rb:269:in `block (3 levels) in <main>'
	from /local/jbriance/WebKit/buildbot-env/webkit-dfg/Source/JavaScriptCore/offlineasm/settings.rb:89:in `forSettings'
	from /local/jbriance/WebKit/buildbot-env/webkit-dfg/Source/JavaScriptCore/offlineasm/asm.rb:265:in `block (2 levels) in <main>'
	from /local/jbriance/WebKit/buildbot-env/webkit-dfg/Source/JavaScriptCore/offlineasm/asm.rb:261:in `each'
	from /local/jbriance/WebKit/buildbot-env/webkit-dfg/Source/JavaScriptCore/offlineasm/asm.rb:261:in `block in <main>'
	from /local/jbriance/WebKit/buildbot-env/webkit-dfg/Source/JavaScriptCore/offlineasm/asm.rb:252:in `open'
	from /local/jbriance/WebKit/buildbot-env/webkit-dfg/Source/JavaScriptCore/offlineasm/asm.rb:252:in `<main>'
make[3]: *** [generated/./LLIntAssembly.h] Error 1
Comment 2 Julien Brianceau 2013-09-16 00:56:55 PDT
Created attachment 211744 [details]
Handle subp opcode with 3 operands and bpbeq opcode in sh4 LLINT backend.
Comment 3 Andreas Kling 2013-09-16 01:41:43 PDT
Comment on attachment 211744 [details]
Handle subp opcode with 3 operands and bpbeq opcode in sh4 LLINT backend.

rs=me
Comment 4 WebKit Commit Bot 2013-09-16 02:04:34 PDT
Comment on attachment 211744 [details]
Handle subp opcode with 3 operands and bpbeq opcode in sh4 LLINT backend.

Clearing flags on attachment: 211744

Committed r155846: <http://trac.webkit.org/changeset/155846>
Comment 5 WebKit Commit Bot 2013-09-16 02:04:38 PDT
All reviewed patches have been landed.  Closing bug.