Bug 121371 - It should be easy to add new nodes that do OSR forward rewiring in both DFG and FTL
Summary: It should be easy to add new nodes that do OSR forward rewiring in both DFG a...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 121064
  Show dependency tree / graph
 
Reported: 2013-09-14 15:14 PDT by Filip Pizlo
Modified: 2013-09-14 17:56 PDT (History)
8 users (show)

See Also:

Attachments
the patch (12.91 KB, patch)
2013-09-14 15:53 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
the patch (14.00 KB, patch)
2013-09-14 16:39 PDT, Filip Pizlo 		sam: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2013-09-14 15:14:29 PDT 
Patch forthcoming.
Comment 1 Filip Pizlo 2013-09-14 15:53:28 PDT 
Created attachment 211672 [details]
the patch
Comment 2 WebKit Commit Bot 2013-09-14 15:55:57 PDT 
Attachment 211672 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/dfg/DFGMinifiedNode.h', u'Source/JavaScriptCore/dfg/DFGNodeType.h', u'Source/JavaScriptCore/dfg/DFGVariableEventStream.cpp', u'Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp']" exit_code: 1
Source/JavaScriptCore/dfg/DFGNodeType.h:310:  Missing space before ( in switch(  [whitespace/parens] [5]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Filip Pizlo 2013-09-14 15:57:32 PDT 
(In reply to comment #2)
> Attachment 211672 [details] did not pass style-queue:
> 
> Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/dfg/DFGMinifiedNode.h', u'Source/JavaScriptCore/dfg/DFGNodeType.h', u'Source/JavaScriptCore/dfg/DFGVariableEventStream.cpp', u'Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp']" exit_code: 1
> Source/JavaScriptCore/dfg/DFGNodeType.h:310:  Missing space before ( in switch(  [whitespace/parens] [5]

Fixed.

> Total errors found: 1 in 5 files
> 
> 
> If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Filip Pizlo 2013-09-14 16:06:54 PDT 
Comment on attachment 211672 [details]
the patch

I think I can do better.
Comment 5 Filip Pizlo 2013-09-14 16:39:05 PDT 
Created attachment 211675 [details]
the patch
Comment 6 Filip Pizlo 2013-09-14 17:56:56 PDT 
Landed in http://trac.webkit.org/changeset/155793