Bug 121369 – [GTK] GObject DOM bindings for Console::profile(), Console::profileEnd() are improperly generated

• Status: NEW
• Component: WebKitGTK

[Zan Dobersek]

This became a problem with changes in r155774, with the Console methods now taking JSC::ExecState as the first argument.
http://trac.webkit.org/changeset/155774

These are the generated bindings functions, causing compilation failures:
void
webkit_dom_console_profile(WebKitDOMConsole* self, const gchar* title)
{
#if ENABLE(JAVASCRIPT_DEBUGGER)
    WebCore::JSMainThreadNullState state;
    g_return_if_fail(WEBKIT_DOM_IS_CONSOLE(self));
    g_return_if_fail(title);
    WebCore::Console* item = WebKit::core(self);
    WTF::String convertedTitle = WTF::String::fromUTF8(title);
    item->profile(convertedTitle);
#else
    WEBKIT_WARN_FEATURE_NOT_PRESENT("Javascript Debugger")
#endif /* ENABLE(JAVASCRIPT_DEBUGGER) */
}

void
webkit_dom_console_profile_end(WebKitDOMConsole* self, const gchar* title)
{
#if ENABLE(JAVASCRIPT_DEBUGGER)
    WebCore::JSMainThreadNullState state;
    g_return_if_fail(WEBKIT_DOM_IS_CONSOLE(self));
    g_return_if_fail(title);
    WebCore::Console* item = WebKit::core(self);
    WTF::String convertedTitle = WTF::String::fromUTF8(title);
    item->profileEnd(convertedTitle);
#else
    WEBKIT_WARN_FEATURE_NOT_PRESENT("Javascript Debugger")
#endif /* ENABLE(JAVASCRIPT_DEBUGGER) */
}

[Andres Gomez Garcia]

I will take a look to this ...

[Andres Gomez Garcia]

(In reply to comment #1)
> I will take a look to this ...

I'm not finding time for this so, please, take this task freely.