Bug 121369 - [GTK] GObject DOM bindings for Console::profile(), Console::profileEnd() are improperly generated
Summary: [GTK] GObject DOM bindings for Console::profile(), Console::profileEnd() are ...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2013-09-14 14:03 PDT by Zan Dobersek
Modified: 2017-03-11 10:49 PST (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2013-09-14 14:03:33 PDT
This became a problem with changes in r155774, with the Console methods now taking JSC::ExecState as the first argument.
http://trac.webkit.org/changeset/155774

These are the generated bindings functions, causing compilation failures:
void
webkit_dom_console_profile(WebKitDOMConsole* self, const gchar* title)
{
#if ENABLE(JAVASCRIPT_DEBUGGER)
    WebCore::JSMainThreadNullState state;
    g_return_if_fail(WEBKIT_DOM_IS_CONSOLE(self));
    g_return_if_fail(title);
    WebCore::Console* item = WebKit::core(self);
    WTF::String convertedTitle = WTF::String::fromUTF8(title);
    item->profile(convertedTitle);
#else
    WEBKIT_WARN_FEATURE_NOT_PRESENT("Javascript Debugger")
#endif /* ENABLE(JAVASCRIPT_DEBUGGER) */
}

void
webkit_dom_console_profile_end(WebKitDOMConsole* self, const gchar* title)
{
#if ENABLE(JAVASCRIPT_DEBUGGER)
    WebCore::JSMainThreadNullState state;
    g_return_if_fail(WEBKIT_DOM_IS_CONSOLE(self));
    g_return_if_fail(title);
    WebCore::Console* item = WebKit::core(self);
    WTF::String convertedTitle = WTF::String::fromUTF8(title);
    item->profileEnd(convertedTitle);
#else
    WEBKIT_WARN_FEATURE_NOT_PRESENT("Javascript Debugger")
#endif /* ENABLE(JAVASCRIPT_DEBUGGER) */
}
Comment 1 Andres Gomez Garcia 2013-10-18 06:23:33 PDT
I will take a look to this ...
Comment 2 Andres Gomez Garcia 2014-10-01 07:42:38 PDT
(In reply to comment #1)
> I will take a look to this ...

I'm not finding time for this so, please, take this task freely.