RESOLVED FIXED Bug 121368
[CTTE] Node subclasses should take a Document by reference in their constructor (Part 3) 
https://bugs.webkit.org/show_bug.cgi?id=121368
Summary [CTTE] Node subclasses should take a Document by reference in their construct...
Sam Weinig
Reported 2013-09-14 14:02:27 PDT
[CTTE] Node subclasses should take a Document by reference in their constructor (Part 3)
Attachments
Patch (107.74 KB, patch)
2013-09-14 14:14 PDT, Sam Weinig 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2013-09-14 14:14:19 PDT
Created attachment 211667 [details] Patch
WebKit Commit Bot
Comment 2 2013-09-14 14:16:33 PDT
Attachment 211667 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/dom/Document.cpp', u'Source/WebCore/editing/DeleteButton.cpp', u'Source/WebCore/editing/DeleteButton.h', u'Source/WebCore/editing/DeleteButtonController.cpp', u'Source/WebCore/editing/EditorCommand.cpp', u'Source/WebCore/editing/htmlediting.cpp', u'Source/WebCore/html/BaseChooserOnlyDateAndTimeInputType.cpp', u'Source/WebCore/html/ColorInputType.cpp', u'Source/WebCore/html/FileInputType.cpp', u'Source/WebCore/html/HTMLBDIElement.h', u'Source/WebCore/html/HTMLBRElement.cpp', u'Source/WebCore/html/HTMLBRElement.h', u'Source/WebCore/html/HTMLBaseElement.cpp', u'Source/WebCore/html/HTMLBaseElement.h', u'Source/WebCore/html/HTMLBaseFontElement.cpp', u'Source/WebCore/html/HTMLBaseFontElement.h', u'Source/WebCore/html/HTMLButtonElement.cpp', u'Source/WebCore/html/HTMLButtonElement.h', u'Source/WebCore/html/HTMLCanvasElement.cpp', u'Source/WebCore/html/HTMLCanvasElement.h', u'Source/WebCore/html/HTMLDListElement.cpp', u'Source/WebCore/html/HTMLDListElement.h', u'Source/WebCore/html/HTMLDataListElement.cpp', u'Source/WebCore/html/HTMLDataListElement.h', u'Source/WebCore/html/HTMLDetailsElement.cpp', u'Source/WebCore/html/HTMLDetailsElement.h', u'Source/WebCore/html/HTMLDirectoryElement.cpp', u'Source/WebCore/html/HTMLDirectoryElement.h', u'Source/WebCore/html/HTMLDivElement.cpp', u'Source/WebCore/html/HTMLDivElement.h', u'Source/WebCore/html/HTMLElement.cpp', u'Source/WebCore/html/HTMLEmbedElement.cpp', u'Source/WebCore/html/HTMLEmbedElement.h', u'Source/WebCore/html/HTMLFieldSetElement.cpp', u'Source/WebCore/html/HTMLFieldSetElement.h', u'Source/WebCore/html/HTMLFontElement.cpp', u'Source/WebCore/html/HTMLFontElement.h', u'Source/WebCore/html/HTMLFormElement.cpp', u'Source/WebCore/html/HTMLFormElement.h', u'Source/WebCore/html/HTMLFrameElement.cpp', u'Source/WebCore/html/HTMLFrameElement.h', u'Source/WebCore/html/HTMLFrameSetElement.cpp', u'Source/WebCore/html/HTMLFrameSetElement.h', u'Source/WebCore/html/HTMLHRElement.cpp', u'Source/WebCore/html/HTMLHRElement.h', u'Source/WebCore/html/HTMLHeadElement.cpp', u'Source/WebCore/html/HTMLHeadElement.h', u'Source/WebCore/html/HTMLHeadingElement.cpp', u'Source/WebCore/html/HTMLHeadingElement.h', u'Source/WebCore/html/HTMLHtmlElement.cpp', u'Source/WebCore/html/HTMLHtmlElement.h', u'Source/WebCore/html/HTMLIFrameElement.cpp', u'Source/WebCore/html/HTMLIFrameElement.h', u'Source/WebCore/html/HTMLImageElement.cpp', u'Source/WebCore/html/HTMLImageElement.h', u'Source/WebCore/html/HTMLInputElement.cpp', u'Source/WebCore/html/HTMLInputElement.h', u'Source/WebCore/html/HTMLKeygenElement.cpp', u'Source/WebCore/html/HTMLKeygenElement.h', u'Source/WebCore/html/HTMLLIElement.cpp', u'Source/WebCore/html/HTMLLIElement.h', u'Source/WebCore/html/HTMLLabelElement.cpp', u'Source/WebCore/html/HTMLLabelElement.h', u'Source/WebCore/html/HTMLLegendElement.cpp', u'Source/WebCore/html/HTMLLegendElement.h', u'Source/WebCore/html/HTMLLinkElement.cpp', u'Source/WebCore/html/HTMLLinkElement.h', u'Source/WebCore/html/HTMLModElement.cpp', u'Source/WebCore/html/HTMLModElement.h', u'Source/WebCore/html/HTMLPreElement.cpp', u'Source/WebCore/html/HTMLPreElement.h', u'Source/WebCore/html/HTMLQuoteElement.cpp', u'Source/WebCore/html/HTMLQuoteElement.h', u'Source/WebCore/html/HTMLSummaryElement.cpp', u'Source/WebCore/html/HTMLTableCaptionElement.cpp', u'Source/WebCore/html/HTMLTableCaptionElement.h', u'Source/WebCore/html/HTMLTableColElement.cpp', u'Source/WebCore/html/HTMLTableColElement.h', u'Source/WebCore/html/HTMLTableElement.cpp', u'Source/WebCore/html/HTMLTagNames.in', u'Source/WebCore/html/HTMLTextAreaElement.cpp', u'Source/WebCore/html/HTMLTextFormControlElement.cpp', u'Source/WebCore/html/HTMLViewSourceDocument.cpp', u'Source/WebCore/html/ImageDocument.cpp', u'Source/WebCore/html/RangeInputType.cpp', u'Source/WebCore/html/TextFieldInputType.cpp', u'Source/WebCore/html/ValidationMessage.cpp', u'Source/WebCore/html/parser/HTMLConstructionSite.cpp', u'Source/WebCore/html/shadow/DetailsMarkerControl.cpp', u'Source/WebCore/html/shadow/DetailsMarkerControl.h', u'Source/WebCore/html/shadow/MediaControlElementTypes.cpp', u'Source/WebCore/html/shadow/MediaControls.cpp', u'Source/WebCore/html/shadow/MediaControlsApple.cpp', u'Source/WebCore/html/shadow/MeterShadowElement.cpp', u'Source/WebCore/html/shadow/ProgressShadowElement.cpp', u'Source/WebCore/html/shadow/SliderThumbElement.cpp', u'Source/WebCore/html/shadow/SpinButtonElement.cpp', u'Source/WebCore/html/shadow/TextControlInnerElements.cpp']" exit_code: 1 Source/WebCore/html/HTMLDetailsElement.h:30: The parameter name "document" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 99 files If any of these errors are false positives, please file a bug against check-webkit-style.
Sam Weinig
Comment 3 2013-09-14 14:32:10 PDT
Committed r155786: <http://trac.webkit.org/changeset/155786>
Note You need to log in before you can comment on or make changes to this bug.