Bug 121364 - Shrink the listMarkerText function
Summary: Shrink the listMarkerText function
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-14 12:02 PDT by Darin Adler
Modified: 2013-09-14 13:10 PDT (History)
4 users (show)

See Also:


Attachments
Patch (33.14 KB, patch)
2013-09-14 12:24 PDT, Darin Adler
kling: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2013-09-14 12:02:59 PDT
Shrink the listMarkerText function
Comment 1 Darin Adler 2013-09-14 12:24:12 PDT
Created attachment 211661 [details]
Patch
Comment 2 WebKit Commit Bot 2013-09-14 12:25:42 PDT
Attachment 211661 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/rendering/RenderListMarker.cpp']" exit_code: 1
Source/WebCore/rendering/RenderListMarker.cpp:335:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Darin Adler 2013-09-14 13:10:01 PDT
Committed r155781: <http://trac.webkit.org/changeset/155781>