Bug 121359 - REGRESSION(r155228): Call to DragData::asFragment() nullifies PassRefPtr<Range> in documentFragmentFromDragData
Summary: REGRESSION(r155228): Call to DragData::asFragment() nullifies PassRefPtr<Rang...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-14 10:00 PDT by Zan Dobersek
Modified: 2013-09-14 14:10 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.91 KB, patch)
2013-09-14 10:02 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2013-09-14 10:00:20 PDT 
REGRESSION(r155228): Call to DragData::asFragment() nullifies PassRefPtr<Range> in documentFragmentFromDragData
Comment 1 Zan Dobersek 2013-09-14 10:02:50 PDT 
Created attachment 211652 [details]
Patch
Comment 2 Zan Dobersek 2013-09-14 10:06:18 PDT 
The regressions after r155228 seem to be specific to the GTK port that doesn't necessarily return a valid DocumentFragment in DragData::asFragment, but can't produce the expected results anymore after the PassRefPtr<Range> in documentFragmentAsText() is left null.
http://build.webkit.org/results/GTK%20Linux%2064-bit%20Release/r155768%20(40745)/results.html
Comment 3 Darin Adler 2013-09-14 14:01:58 PDT 
Comment on attachment 211652 [details]
Patch

Oops!
Comment 4 Zan Dobersek 2013-09-14 14:10:42 PDT 
Comment on attachment 211652 [details]
Patch

Clearing flags on attachment: 211652

Committed r155785: <http://trac.webkit.org/changeset/155785>
Comment 5 Zan Dobersek 2013-09-14 14:10:49 PDT 
All reviewed patches have been landed.  Closing bug.