Bug 121356 - [GTK] WebKitGTK+ is linking against libxslt in too many places
Summary: [GTK] WebKitGTK+ is linking against libxslt in too many places
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alberto Garcia
Depends on:
Reported: 2013-09-14 08:07 PDT by Alberto Garcia
Modified: 2013-09-14 09:11 PDT (History)
6 users (show)

See Also:

Patch (5.40 KB, patch)
2013-09-14 08:16 PDT, Alberto Garcia
mrobinson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alberto Garcia 2013-09-14 08:07:54 PDT
This is a follow-up to bug 119688.

We're linking against libxslt in too many places.

As far as I can see, libxslt is only used in a few files inside
WebCore ( Source/WebCore/xml/XSL*.cpp ) so:

 - LIBXSLT_CFLAGS is only needed for those files (listed in
   webcore_sources, defined in Source/WebCore/GNUmakefile.list.am).

 - LIBXSLT_LIBS is only needed in the libraries that include webcore,
   that is: libwebkitgtk, libwebkit2gtk and webkitpluginprocess.

We can remove LIBXSLT_CFLAGS from the following places, because they
don't include any of the source files that use libxslt:

 - libWebCorePlatform_la_CPPFLAGS
 - libWebCoreGtk_la_CPPFLAGS
 - libwebkitgtk_<version>_la_CPPFLAGS
 - libWebCoreGtk2_la_CPPFLAGS.

And we can remove LIBXSLT_LIBS from the following places, which don't
need to link against libxslt.

 - webkit_tests_ldadd
 - Programs_MiniBrowser_LDADD
 - Programs_TestWebKitAPI_TestWebCore_LDADD
 - Programs_WebKitTestRunner_LDADD
Comment 1 Alberto Garcia 2013-09-14 08:16:35 PDT
Created attachment 211647 [details]

Here's the patch, I built r155767 from scratch twice, release and debug builds, and everything seems to work fine.
Comment 2 Alberto Garcia 2013-09-14 08:18:43 PDT
I'm using the gold linker btw.
Comment 3 Martin Robinson 2013-09-14 08:50:56 PDT
Comment on attachment 211647 [details]

Comment 4 Alberto Garcia 2013-09-14 09:11:36 PDT
Committed r155768: <http://trac.webkit.org/changeset/155768>