Bug 121356 – [GTK] WebKitGTK+ is linking against libxslt in too many places

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Alberto Garcia]

This is a follow-up to bug 119688.

We're linking against libxslt in too many places.

As far as I can see, libxslt is only used in a few files inside
WebCore ( Source/WebCore/xml/XSL*.cpp ) so:

 - LIBXSLT_CFLAGS is only needed for those files (listed in
   webcore_sources, defined in Source/WebCore/GNUmakefile.list.am).

 - LIBXSLT_LIBS is only needed in the libraries that include webcore,
   that is: libwebkitgtk, libwebkit2gtk and webkitpluginprocess.

We can remove LIBXSLT_CFLAGS from the following places, because they
don't include any of the source files that use libxslt:

 - libWebCorePlatform_la_CPPFLAGS
 - libWebCoreGtk_la_CPPFLAGS
 - libwebkitgtk_<version>_la_CPPFLAGS
 - libWebCoreGtk2_la_CPPFLAGS.

And we can remove LIBXSLT_LIBS from the following places, which don't
need to link against libxslt.

 - webkit_tests_ldadd
 - Programs_MiniBrowser_LDADD
 - Programs_TestWebKitAPI_TestWebCore_LDADD
 - Programs_WebKitTestRunner_LDADD

[Alberto Garcia]

Created attachment 211647 [details]
Patch

Here's the patch, I built r155767 from scratch twice, release and debug builds, and everything seems to work fine.

[Alberto Garcia]

I'm using the gold linker btw.

[Martin Robinson]

Comment on attachment 211647 [details]
Patch

Thanks.

[Alberto Garcia]

Committed r155768: <http://trac.webkit.org/changeset/155768>