RESOLVED FIXED 121345
CTTE: RenderSVGResourceMarker always has an SVGMarkerElement. 
https://bugs.webkit.org/show_bug.cgi?id=121345
Summary CTTE: RenderSVGResourceMarker always has an SVGMarkerElement.
Andreas Kling
Reported 2013-09-13 22:38:20 PDT
CTTE: RenderSVGResourceMarker always has an SVGMarkerElement.
Attachments
Patch (8.00 KB, patch)
2013-09-13 22:40 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2013-09-13 22:40:13 PDT
Created attachment 211622 [details] Patch
Brent Fulgham
Comment 2 2013-09-13 23:03:20 PDT
Comment on attachment 211622 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=211622&action=review r=me. I had question about the "renderName" method, but otherwise it looks good to me. > Source/WebCore/rendering/svg/RenderSVGResourceMarker.h:38 > + explicit RenderSVGResourceMarker(SVGMarkerElement&); Yes! > Source/WebCore/rendering/svg/RenderSVGResourceMarker.h:-41 > - virtual const char* renderName() const { return "RenderSVGResourceMarker"; } Is this stuff not needed for printing render tree dumps?
Andreas Kling
Comment 3 2013-09-13 23:30:27 PDT
Comment on attachment 211622 [details] Patch Clearing flags on attachment: 211622 Committed r155750: <http://trac.webkit.org/changeset/155750>
Andreas Kling
Comment 4 2013-09-13 23:30:33 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.