Bug 121338 - There is no need for any custom bindings for Console
Summary: There is no need for any custom bindings for Console
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on: 121342
Blocks:
  Show dependency treegraph
 
Reported: 2013-09-13 18:39 PDT by Sam Weinig
Modified: 2013-09-14 11:28 PDT (History)
11 users (show)

See Also:


Attachments
Patch (22.10 KB, patch)
2013-09-13 18:42 PDT, Sam Weinig
no flags Details | Formatted Diff | Diff
Updated patch (22.14 KB, patch)
2013-09-14 11:22 PDT, Sam Weinig
timothy: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2013-09-13 18:39:06 PDT
There is no need for any custom bindings for Console
Comment 1 Sam Weinig 2013-09-13 18:42:16 PDT
Created attachment 211612 [details]
Patch
Comment 2 Joseph Pecoraro 2013-09-13 18:45:49 PDT
Comment on attachment 211612 [details]
Patch

r=me!
Comment 3 Sam Weinig 2013-09-13 18:49:48 PDT
Committed r155738: <http://trac.webkit.org/changeset/155738>
Comment 4 WebKit Commit Bot 2013-09-13 21:41:15 PDT
Re-opened since this is blocked by bug 121342
Comment 5 Alexey Proskuryakov 2013-09-13 21:41:42 PDT
This change broke lots of tests and Sam is not online, rolling out.

http://build.webkit.org/results/Apple%20Lion%20Release%20WK1%20(Tests)/r155741%20(15389)/results.html
Comment 6 Sam Weinig 2013-09-14 11:22:47 PDT
Created attachment 211657 [details]
Updated patch
Comment 7 Sam Weinig 2013-09-14 11:23:22 PDT
Updated patch to mark the title parameter as optional (which was what broke the tests).
Comment 8 Sam Weinig 2013-09-14 11:28:28 PDT
Committed r155774: <http://trac.webkit.org/changeset/155774>