Bug 121336 - Replace ScriptState with JSC::ExecState
Summary: Replace ScriptState with JSC::ExecState
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-13 18:08 PDT by Sam Weinig
Modified: 2013-09-13 18:33 PDT (History)
6 users (show)

See Also:


Attachments
Patch (130.26 KB, patch)
2013-09-13 18:13 PDT, Sam Weinig
no flags Details | Formatted Diff | Diff
Patch (131.13 KB, patch)
2013-09-13 18:21 PDT, Sam Weinig
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2013-09-13 18:08:24 PDT
Replace ScriptState with JSC::ExecState
Comment 1 Sam Weinig 2013-09-13 18:13:35 PDT
Created attachment 211609 [details]
Patch
Comment 2 WebKit Commit Bot 2013-09-13 18:14:51 PDT
Attachment 211609 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/Modules/indexeddb/IDBCursor.h', u'Source/WebCore/Modules/indexeddb/IDBObjectStore.h', u'Source/WebCore/bindings/js/JSInjectedScriptHostCustom.cpp', u'Source/WebCore/bindings/js/JSInjectedScriptManager.cpp', u'Source/WebCore/bindings/js/JSNodeCustom.cpp', u'Source/WebCore/bindings/js/JSNodeFilterCondition.h', u'Source/WebCore/bindings/js/ScriptController.cpp', u'Source/WebCore/bindings/js/ScriptDebugServer.cpp', u'Source/WebCore/bindings/js/ScriptDebugServer.h', u'Source/WebCore/bindings/js/ScriptEventListener.cpp', u'Source/WebCore/bindings/js/ScriptEventListener.h', u'Source/WebCore/bindings/js/ScriptFunctionCall.cpp', u'Source/WebCore/bindings/js/ScriptFunctionCall.h', u'Source/WebCore/bindings/js/ScriptObject.cpp', u'Source/WebCore/bindings/js/ScriptObject.h', u'Source/WebCore/bindings/js/ScriptProfiler.cpp', u'Source/WebCore/bindings/js/ScriptProfiler.h', u'Source/WebCore/bindings/js/ScriptState.cpp', u'Source/WebCore/bindings/js/ScriptState.h', u'Source/WebCore/bindings/js/ScriptValue.cpp', u'Source/WebCore/bindings/js/ScriptValue.h', u'Source/WebCore/bindings/js/SerializedScriptValue.cpp', u'Source/WebCore/bindings/js/SerializedScriptValue.h', u'Source/WebCore/dom/Document.cpp', u'Source/WebCore/dom/Document.h', u'Source/WebCore/dom/NodeFilter.cpp', u'Source/WebCore/dom/NodeFilter.h', u'Source/WebCore/dom/NodeFilterCondition.cpp', u'Source/WebCore/dom/NodeFilterCondition.h', u'Source/WebCore/dom/NodeIterator.cpp', u'Source/WebCore/dom/NodeIterator.h', u'Source/WebCore/dom/ScriptExecutionContext.cpp', u'Source/WebCore/dom/ScriptExecutionContext.h', u'Source/WebCore/dom/Traversal.cpp', u'Source/WebCore/dom/Traversal.h', u'Source/WebCore/dom/TreeWalker.cpp', u'Source/WebCore/dom/TreeWalker.h', u'Source/WebCore/inspector/ConsoleMessage.cpp', u'Source/WebCore/inspector/ConsoleMessage.h', u'Source/WebCore/inspector/InjectedScript.h', u'Source/WebCore/inspector/InjectedScriptBase.cpp', u'Source/WebCore/inspector/InjectedScriptBase.h', u'Source/WebCore/inspector/InjectedScriptCanvasModule.cpp', u'Source/WebCore/inspector/InjectedScriptCanvasModule.h', u'Source/WebCore/inspector/InjectedScriptHost.cpp', u'Source/WebCore/inspector/InjectedScriptHost.h', u'Source/WebCore/inspector/InjectedScriptManager.cpp', u'Source/WebCore/inspector/InjectedScriptManager.h', u'Source/WebCore/inspector/InjectedScriptModule.cpp', u'Source/WebCore/inspector/InjectedScriptModule.h', u'Source/WebCore/inspector/InspectorAgent.cpp', u'Source/WebCore/inspector/InspectorCanvasAgent.cpp', u'Source/WebCore/inspector/InspectorCanvasAgent.h', u'Source/WebCore/inspector/InspectorConsoleAgent.cpp', u'Source/WebCore/inspector/InspectorConsoleAgent.h', u'Source/WebCore/inspector/InspectorConsoleInstrumentation.h', u'Source/WebCore/inspector/InspectorDOMAgent.cpp', u'Source/WebCore/inspector/InspectorDebuggerAgent.cpp', u'Source/WebCore/inspector/InspectorDebuggerAgent.h', u'Source/WebCore/inspector/InspectorFrontendClientLocal.cpp', u'Source/WebCore/inspector/InspectorFrontendHost.cpp', u'Source/WebCore/inspector/InspectorIndexedDBAgent.cpp', u'Source/WebCore/inspector/InspectorInstrumentation.cpp', u'Source/WebCore/inspector/InspectorInstrumentation.h', u'Source/WebCore/inspector/PageConsoleAgent.cpp', u'Source/WebCore/inspector/PageDebuggerAgent.cpp', u'Source/WebCore/inspector/PageRuntimeAgent.cpp', u'Source/WebCore/inspector/PageRuntimeAgent.h', u'Source/WebCore/inspector/ScriptArguments.cpp', u'Source/WebCore/inspector/ScriptArguments.h', u'Source/WebCore/inspector/ScriptDebugListener.h', u'Source/WebCore/inspector/WorkerDebuggerAgent.cpp', u'Source/WebCore/inspector/WorkerRuntimeAgent.cpp', u'Source/WebCore/page/Console.cpp', u'Source/WebCore/page/Console.h', u'Source/WebCore/page/ContentSecurityPolicy.cpp', u'Source/WebCore/page/ContentSecurityPolicy.h', u'Source/WebCore/page/PageConsole.cpp', u'Source/WebCore/page/PageConsole.h', u'Source/WebCore/workers/WorkerGlobalScope.cpp', u'Source/WebCore/workers/WorkerGlobalScope.h']" exit_code: 1
Source/WebCore/bindings/js/ScriptProfiler.h:62:  The parameter name "state" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/bindings/js/ScriptProfiler.h:67:  The parameter name "state" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 82 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Anders Carlsson 2013-09-13 18:19:05 PDT
Comment on attachment 211609 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=211609&action=review

>> Source/WebCore/bindings/js/ScriptProfiler.h:62
>> +    static void start(JSC::ExecState* state, const String& title);
> 
> The parameter name "state" adds no information, so it should be removed.  [readability/parameter_name] [5]

Yes please.

>> Source/WebCore/bindings/js/ScriptProfiler.h:67
>> +    static PassRefPtr<ScriptProfile> stop(JSC::ExecState* state, const String& title);
> 
> The parameter name "state" adds no information, so it should be removed.  [readability/parameter_name] [5]

Ditto.
Comment 4 Sam Weinig 2013-09-13 18:21:38 PDT
Created attachment 211610 [details]
Patch
Comment 5 Darin Adler 2013-09-13 18:27:05 PDT
Comment on attachment 211610 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=211610&action=review

> Source/WebCore/dom/Document.cpp:862
> +PassRefPtr<CustomElementConstructor> Document::registerElement(WebCore::JSC::ExecState* state, const AtomicString& name, ExceptionCode& ec)

WebCore::JSC? No!

> Source/WebCore/dom/Document.cpp:867
> +PassRefPtr<CustomElementConstructor> Document::registerElement(WebCore::JSC::ExecState* state, const AtomicString& name, const Dictionary& options, ExceptionCode& ec)

Ditto.

> Source/WebCore/dom/Document.h:1142
> +    PassRefPtr<CustomElementConstructor> registerElement(WebCore::JSC::ExecState*, const AtomicString& name, ExceptionCode&);
> +    PassRefPtr<CustomElementConstructor> registerElement(WebCore::JSC::ExecState*, const AtomicString& name, const Dictionary& options, ExceptionCode&);

WebCore::JSC? No!
Comment 6 Sam Weinig 2013-09-13 18:28:28 PDT
(In reply to comment #5)
> (From update of attachment 211610 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=211610&action=review
> 
> > Source/WebCore/dom/Document.cpp:862
> > +PassRefPtr<CustomElementConstructor> Document::registerElement(WebCore::JSC::ExecState* state, const AtomicString& name, ExceptionCode& ec)
> 
> WebCore::JSC? No!
> 
> > Source/WebCore/dom/Document.cpp:867
> > +PassRefPtr<CustomElementConstructor> Document::registerElement(WebCore::JSC::ExecState* state, const AtomicString& name, const Dictionary& options, ExceptionCode& ec)
> 
> Ditto.
> 
> > Source/WebCore/dom/Document.h:1142
> > +    PassRefPtr<CustomElementConstructor> registerElement(WebCore::JSC::ExecState*, const AtomicString& name, ExceptionCode&);
> > +    PassRefPtr<CustomElementConstructor> registerElement(WebCore::JSC::ExecState*, const AtomicString& name, const Dictionary& options, ExceptionCode&);
> 
> WebCore::JSC? No!

I wonder if anyone compiles with ENABLE(CUSTOM_ELEMENTS) on.
Comment 7 Sam Weinig 2013-09-13 18:33:15 PDT
Committed r155736: <http://trac.webkit.org/changeset/155736>