Bug 121302 – [CTTE] Tighter element types for RenderSVGShape and subclasses.

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Andreas Kling]

[CTTE] Tighter element types for RenderSVGShape and subclasses.

[Andreas Kling]

Created attachment 211556 [details]
Patch

[WebKit Commit Bot]

Attachment 211556 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/rendering/svg/RenderSVGEllipse.cpp', u'Source/WebCore/rendering/svg/RenderSVGEllipse.h', u'Source/WebCore/rendering/svg/RenderSVGPath.cpp', u'Source/WebCore/rendering/svg/RenderSVGPath.h', u'Source/WebCore/rendering/svg/RenderSVGRect.cpp', u'Source/WebCore/rendering/svg/RenderSVGRect.h', u'Source/WebCore/rendering/svg/RenderSVGShape.cpp', u'Source/WebCore/rendering/svg/RenderSVGShape.h', u'Source/WebCore/rendering/svg/SVGRenderTreeAsText.cpp', u'Source/WebCore/svg/SVGCircleElement.cpp', u'Source/WebCore/svg/SVGEllipseElement.cpp', u'Source/WebCore/svg/SVGGraphicsElement.cpp', u'Source/WebCore/svg/SVGPathElement.cpp', u'Source/WebCore/svg/SVGPolyElement.h', u'Source/WebCore/svg/SVGRectElement.cpp']" exit_code: 1
Source/WebCore/rendering/svg/RenderSVGRect.cpp:62:  An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Total errors found: 1 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Antti Koivisto]

Comment on attachment 211556 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=211556&action=review

> Source/WebCore/svg/SVGPolyElement.h:72
> +inline SVGPolyElement& toSVGPolyElement(SVGElement& element)
> +{
> +    ASSERT_WITH_SECURITY_IMPLICATION(element.hasTagName(SVGNames::polygonTag) || element.hasTagName(SVGNames::polylineTag));
> +    return static_cast<SVGPolyElement&>(element);
> +}

Would be cool if the autogen script could handle these.

[Andreas Kling]

Committed r155704: <http://trac.webkit.org/changeset/155704>