WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
121288
Remove support for anonymous deprecated flexboxes.
https://bugs.webkit.org/show_bug.cgi?id=121288
Summary
Remove support for anonymous deprecated flexboxes.
Andreas Kling
Reported
2013-09-13 03:44:02 PDT
Looks like this is not needed anymore.
Attachments
Patch
(5.59 KB, patch)
2013-09-13 03:59 PDT
,
Andreas Kling
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Andreas Kling
Comment 1
2013-09-13 03:59:14 PDT
Created
attachment 211533
[details]
Patch
Antti Koivisto
Comment 2
2013-09-13 04:03:02 PDT
Nice!
Antti Koivisto
Comment 3
2013-09-13 04:04:01 PDT
Comment on
attachment 211533
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=211533&action=review
> Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp:-135 > - FeatureObserver::observe(&document(), FeatureObserver::DeprecatedFlexboxChrome); > - else if (url.protocolIs("chrome-extension")) > - FeatureObserver::observe(&document(), FeatureObserver::DeprecatedFlexboxChromeExtension); > - else > - FeatureObserver::observe(&document(), FeatureObserver::DeprecatedFlexboxWebContent);
I guess we can nuke those FeatureObserver enum values too.
Andreas Kling
Comment 4
2013-09-13 05:21:33 PDT
Comment on
attachment 211533
[details]
Patch Clearing flags on attachment: 211533 Committed
r155689
: <
http://trac.webkit.org/changeset/155689
>
Andreas Kling
Comment 5
2013-09-13 05:21:38 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug