RESOLVED FIXED 121283
[CTTE] Tighter element types for RenderSVGInline and subclasses. 
https://bugs.webkit.org/show_bug.cgi?id=121283
Summary [CTTE] Tighter element types for RenderSVGInline and subclasses.
Andreas Kling
Reported 2013-09-13 02:04:40 PDT
[CTTE] Tighter element types for RenderSVGInline and subclasses.
Attachments
Patch (17.31 KB, patch)
2013-09-13 02:06 PDT, Andreas Kling 		koivisto: review-
webkit-ews: commit-queue-
DetailsFormatted DiffDiff
Patch (17.47 KB, patch)
2013-09-13 02:24 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Patch (17.47 KB, patch)
2013-09-13 02:26 PDT, Andreas Kling 		koivisto: review+
webkit-ews: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2013-09-13 02:06:08 PDT
Created attachment 211521 [details] Patch
Early Warning System Bot
Comment 2 2013-09-13 02:11:07 PDT
Comment on attachment 211521 [details] Patch Attachment 211521 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1868061
EFL EWS Bot
Comment 3 2013-09-13 02:11:21 PDT
Comment on attachment 211521 [details] Patch Attachment 211521 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/1895013
EFL EWS Bot
Comment 4 2013-09-13 02:12:19 PDT
Comment on attachment 211521 [details] Patch Attachment 211521 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/1883069
Early Warning System Bot
Comment 5 2013-09-13 02:13:15 PDT
Comment on attachment 211521 [details] Patch Attachment 211521 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1895014
Antti Koivisto
Comment 6 2013-09-13 02:17:30 PDT
Comment on attachment 211521 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=211521&action=review > Source/WebCore/rendering/svg/RenderSVGTSpan.h:37 > + SVGTextPositioningElement& textPositioningElement() const { return static_cast<SVGTextPositioningElement&>(*RenderObject::node()); } please call the closest base class function instead of node()
Andreas Kling
Comment 7 2013-09-13 02:24:41 PDT
Created attachment 211522 [details] Patch
Andreas Kling
Comment 8 2013-09-13 02:26:42 PDT
Created attachment 211523 [details] Patch
Early Warning System Bot
Comment 9 2013-09-13 02:30:08 PDT
Comment on attachment 211523 [details] Patch Attachment 211523 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1892119
Antti Koivisto
Comment 10 2013-09-13 02:31:17 PDT
Comment on attachment 211523 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=211523&action=review > Source/WebCore/rendering/svg/RenderSVGTSpan.h:37 > + SVGTextPositioningElement& textPositioningElement() const { return static_cast<SVGTextPositioningElement&>(RenderSVGInline::graphicsElement()); } I don't think you need to say RenderSVGInline::
Early Warning System Bot
Comment 11 2013-09-13 02:31:38 PDT
Comment on attachment 211523 [details] Patch Attachment 211523 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1881085
Antti Koivisto
Comment 12 2013-09-13 02:33:12 PDT
ah WTF_DELETED_FUNCTION nm
Andreas Kling
Comment 13 2013-09-13 02:47:27 PDT
Committed r155682: <http://trac.webkit.org/changeset/155682>
Note You need to log in before you can comment on or make changes to this bug.