Bug 121279 - Finish removing layer-violating code from Pasteboard (just for Mac during this first step)
Summary: Finish removing layer-violating code from Pasteboard (just for Mac during thi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-12 23:58 PDT by Darin Adler
Modified: 2013-09-13 08:24 PDT (History)
1 user (show)

See Also:

Attachments
Patch (37.42 KB, patch)
2013-09-13 00:27 PDT, Darin Adler 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2013-09-12 23:58:22 PDT 
Finish removing layer-violating code from Pasteboard (just for Mac during this first step)
Comment 1 Darin Adler 2013-09-13 00:27:09 PDT 
Created attachment 211516 [details]
Patch
Comment 2 Anders Carlsson 2013-09-13 07:58:32 PDT 
Comment on attachment 211516 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=211516&action=review

> Source/WebCore/editing/mac/EditorMac.mm:538
> +    String uniqueIDString = adoptCF(CFUUIDCreateString(nullptr, adoptCF(CFUUIDCreate(nullptr)).get())).get();

I think we have our own UUID implementation in WTF if you do't like all the .gets here.

I also think you should use kCFAllocatorDefault instead of nullptr.
Comment 3 Darin Adler 2013-09-13 08:24:12 PDT 
Committed r155700: <http://trac.webkit.org/changeset/155700>