Bug 121268 - DFG::Int32Operand and fillInt32() should go away and all uses should be replaced with SpeculateInt32Operand
Summary: DFG::Int32Operand and fillInt32() should go away and all uses should be repla...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 121064
  Show dependency treegraph
 
Reported: 2013-09-12 16:30 PDT by Filip Pizlo
Modified: 2013-09-12 18:35 PDT (History)
8 users (show)

See Also:


Attachments
the patch (11.67 KB, patch)
2013-09-12 16:31 PDT, Filip Pizlo
oliver: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2013-09-12 16:30:40 PDT
SpeculateInt32Operand is strictly more powerful than Int32Operand.  It can even assert for you that you're not doing a speculation when you shouldn't be doing on, just like Int32Operand does.

So we should get rid of Int32Operand.
Comment 1 Filip Pizlo 2013-09-12 16:31:36 PDT
Created attachment 211491 [details]
the patch
Comment 2 Oliver Hunt 2013-09-12 16:54:03 PDT
Comment on attachment 211491 [details]
the patch

nice
Comment 3 Filip Pizlo 2013-09-12 16:57:28 PDT
Landed in http://trac.webkit.org/changeset/155662
Comment 5 Filip Pizlo 2013-09-12 18:35:05 PDT
(In reply to comment #4)
> This may have introduced crashing on ML Release builds.  See http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK1%20%28Tests%29/r155662%20%2812852%29/media/video-seek-after-end-crash-log.txt.

Seems doubtful.  That's a GC crash.  GC crashes will be spurious to begin with.  This patch changes how the compiler handles integers.  The GC ignores integers.

We should keep an eye on it, though.