Bug 121235 - Remove unneeded casts once we upgrade to a version of Visual Studio that is not broken
Summary: Remove unneeded casts once we upgrade to a version of Visual Studio that is n...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: peavo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-12 10:37 PDT by Brent Fulgham
Modified: 2016-05-02 13:35 PDT (History)
5 users (show)

See Also:

Attachments
Patch (5.69 KB, patch)
2016-05-01 23:15 PDT, peavo 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2013-09-12 10:37:52 PDT 
We had to add casts in a number of places to work around a Visual Studio 2010 compiler bug.  We should revisit this from time to time (perhaps after the switch to VS2012) to see if we can remove these casts.

Locations:
1. WebCore/loader/archive/ArchiveFactory.cpp
2. WebCore/css/MediaQueryEvaluator.cpp
3. Autogenerated Files:
    JSSVGElementWrapperFactory.cpp
    JSHTMLElementWrapperFactory.cpp
   --> Modified in WebCore/dom/make_names.pl
Comment 1 Brent Fulgham 2013-09-12 10:55:04 PDT 
The changes we want to back out were landed in http://trac.webkit.org/changeset/155630.
Comment 2 Eric Carlson 2014-01-29 09:25:39 PST 
Can the unneeded casts be removed now?
Comment 3 Simon Fraser (smfr) 2016-04-28 21:18:04 PDT 
How about now?
Comment 4 Brent Fulgham 2016-04-29 11:25:55 PDT 
(In reply to comment #3)
> How about now?

I'll bet they can!

Per, could you please try and propose a patch?
Comment 5 peavo 2016-05-01 23:15:41 PDT 
Created attachment 277892 [details]
Patch
Comment 6 peavo 2016-05-02 13:34:11 PDT 
Thanks for reviewing :)
Comment 7 peavo 2016-05-02 13:35:12 PDT 
Committed r200336: <http://trac.webkit.org/changeset/200336>