Bug 121230 - SharedBuffer::createCFData should return RetainPtr<CFDataRef>
Summary: SharedBuffer::createCFData should return RetainPtr<CFDataRef>
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-12 09:38 PDT by Anders Carlsson
Modified: 2013-09-12 10:37 PDT (History)
2 users (show)

See Also:

Attachments
Patch (10.94 KB, patch)
2013-09-12 09:39 PDT, Anders Carlsson 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2013-09-12 09:38:22 PDT 
SharedBuffer::createCFData should return RetainPtr<CFDataRef>
Comment 1 Anders Carlsson 2013-09-12 09:39:25 PDT 
Created attachment 211436 [details]
Patch
Comment 2 Darin Adler 2013-09-12 09:40:47 PDT 
Comment on attachment 211436 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=211436&action=review

> Source/WebCore/platform/mac/SharedBufferMac.mm:109
> +    return adoptCF((CFDataRef)adoptNS([[WebCoreSharedBufferData alloc] initWithSharedBuffer:this]).leakRef());

We’ve got to find a better idiom for toll free bridging with RetainPtr than this. It destroys the rule of “look for leakRef” to find bugs.
Comment 3 Anders Carlsson 2013-09-12 10:37:31 PDT 
Committed r155629: <http://trac.webkit.org/changeset/155629>