Bug 121219 (WatchDog) - implement Glib Watchdog which is used to track script execution time, and initiate script termination if needed
Summary: implement Glib Watchdog which is used to track script execution time, and ini...
Status: RESOLVED DUPLICATE of bug 147107
Alias: WatchDog
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-12 02:26 PDT by Peng Xinchao
Modified: 2015-07-28 11:03 PDT (History)
10 users (show)

See Also:

Attachments
patch (4.06 KB, patch)
2013-09-12 02:48 PDT, Peng Xinchao 		no flags Details | Formatted Diff | Diff
new patch (4.54 KB, patch)
2013-09-12 02:52 PDT, Peng Xinchao 		no flags Details | Formatted Diff | Diff
Patch (6.91 KB, patch)
2014-01-06 02:18 PST, Peng Xinchao 		no flags Details | Formatted Diff | Diff
Patch (6.64 KB, patch)
2014-01-06 02:28 PST, Peng Xinchao 		no flags Details | Formatted Diff | Diff
Patch (5.69 KB, patch)
2015-05-18 03:28 PDT, Peng Xinchao 		no flags Details | Formatted Diff | Diff
Patch (4.00 KB, patch)
2015-05-18 03:33 PDT, Peng Xinchao 		no flags Details | Formatted Diff | Diff
Patch (8.36 KB, patch)
2015-05-28 21:21 PDT, Peng Xinchao 		no flags Details | Formatted Diff | Diff
Patch (4.36 KB, patch)
2015-06-01 23:01 PDT, Peng Xinchao 		no flags Details | Formatted Diff | Diff
Patch (7.86 KB, patch)
2015-06-01 23:04 PDT, Peng Xinchao 		no flags Details | Formatted Diff | Diff
Show Obsolete (8) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Peng Xinchao 2013-09-12 02:26:05 PDT 
In the GTK platform , Implement GTK WatchDog
Comment 1 Peng Xinchao 2013-09-12 02:48:37 PDT 
Created attachment 211411 [details]
patch
Comment 2 Peng Xinchao 2013-09-12 02:52:19 PDT 
Created attachment 211412 [details]
new patch 

new patch
Comment 3 Philippe Normand 2013-10-22 04:05:36 PDT 
Please provide a ChangeLog and (re)read http://www.webkit.org/coding/contributing.html :)
Comment 4 Peng Xinchao 2014-01-06 02:18:09 PST 
Created attachment 220424 [details]
Patch
Comment 5 Peng Xinchao 2014-01-06 02:28:19 PST 
Created attachment 220425 [details]
Patch
Comment 6 Csaba Osztrogonác 2015-05-11 03:06:34 PDT 
Comment on attachment 220425 [details]
Patch

It seems this patch a little bit outdated, GTK doesn't hace autoconf build system long time ago.
Comment 7 Peng Xinchao 2015-05-18 03:28:51 PDT 
Created attachment 253320 [details]
Patch
Comment 8 Peng Xinchao 2015-05-18 03:33:34 PDT 
Created attachment 253321 [details]
Patch
Comment 9 Michael Catanzaro 2015-05-18 16:48:57 PDT 
I would expect this to be implemented in a new file, WatchdogGlib.cpp, rather than putting the code into WatchdogNone.cpp which should just hold the stub implementations. It should probably be used for EFL in addition to GTK.

You might have an easier time drawing the attention of a reviewer if you explain the benefit of implementing the watchdog. (Is it used to ensure JSC doesn't hang?)
Comment 10 Peng Xinchao 2015-05-28 21:21:12 PDT 
Created attachment 253892 [details]
Patch
Comment 11 Peng Xinchao 2015-06-01 23:01:05 PDT 
Created attachment 254054 [details]
Patch
Comment 12 Peng Xinchao 2015-06-01 23:04:48 PDT 
Created attachment 254055 [details]
Patch
Comment 13 Michael Catanzaro 2015-06-02 04:50:45 PDT 
Gyuyoung, should this be used for EFL as well? I guess yes, since you already depend on glib through libsoup.
Comment 14 Mark Lam 2015-07-28 09:37:33 PDT 
I recommend dup'ing this bug to https://bugs.webkit.org/show_bug.cgi?id=147107 since 147107 has the discussion for how to solve this in a platform agnostic way.
Comment 15 Michael Catanzaro 2015-07-28 11:02:47 PDT 

*** This bug has been marked as a duplicate of bug 147107 ***